2017-06-27 12:16:00

by Surender Polsani

[permalink] [raw]
Subject: [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes

From: Surender Polsani <[email protected]>

"interrupt-parent" property is declared in root node, so it is global
to all nodes. This property is re-declared in few sub-nodes. To avoid
duplication this property is removed from following sub-nodes:
pmu, amba@0, amba@0/ethernet.

Signed-off-by: Surender Polsani <[email protected]>
---
arch/arm/boot/dts/artpec6.dtsi | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
index 767cbe8..2ed1177 100644
--- a/arch/arm/boot/dts/artpec6.dtsi
+++ b/arch/arm/boot/dts/artpec6.dtsi
@@ -151,7 +151,6 @@
interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
interrupt-affinity = <&cpu0>, <&cpu1>;
- interrupt-parent = <&intc>;
};

pcie: pcie@f8050000 {
@@ -185,7 +184,6 @@
compatible = "simple-bus";
#address-cells = <0x1>;
#size-cells = <0x1>;
- interrupt-parent = <&intc>;
ranges;
dma-ranges = <0x80000000 0x00000000 0x40000000>;
dma-coherent;
@@ -195,7 +193,6 @@
clocks = <&eth_phy_ref_clk>,
<&clkctrl ARTPEC6_CLK_ETH_ACLK>;
compatible = "snps,dwc-qos-ethernet-4.10";
- interrupt-parent = <&intc>;
interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
reg = <0xf8010000 0x4000>;

--
1.9.1


2017-06-27 12:27:29

by Niklas Cassel

[permalink] [raw]
Subject: Re: [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes

Acked-by: Niklas Cassel <[email protected]>

On 06/27/2017 02:15 PM, [email protected] wrote:
> From: Surender Polsani <[email protected]>
>
> "interrupt-parent" property is declared in root node, so it is global
> to all nodes. This property is re-declared in few sub-nodes. To avoid
> duplication this property is removed from following sub-nodes:
> pmu, amba@0, amba@0/ethernet.
>
> Signed-off-by: Surender Polsani <[email protected]>
> ---
> arch/arm/boot/dts/artpec6.dtsi | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
> index 767cbe8..2ed1177 100644
> --- a/arch/arm/boot/dts/artpec6.dtsi
> +++ b/arch/arm/boot/dts/artpec6.dtsi
> @@ -151,7 +151,6 @@
> interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
> <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
> interrupt-affinity = <&cpu0>, <&cpu1>;
> - interrupt-parent = <&intc>;
> };
>
> pcie: pcie@f8050000 {
> @@ -185,7 +184,6 @@
> compatible = "simple-bus";
> #address-cells = <0x1>;
> #size-cells = <0x1>;
> - interrupt-parent = <&intc>;
> ranges;
> dma-ranges = <0x80000000 0x00000000 0x40000000>;
> dma-coherent;
> @@ -195,7 +193,6 @@
> clocks = <&eth_phy_ref_clk>,
> <&clkctrl ARTPEC6_CLK_ETH_ACLK>;
> compatible = "snps,dwc-qos-ethernet-4.10";
> - interrupt-parent = <&intc>;
> interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
> reg = <0xf8010000 0x4000>;
>
>

2017-08-11 07:56:26

by Surender Polsani

[permalink] [raw]
Subject: Re: [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes

On Tuesday 27 June 2017 05:57 PM, Niklas Cassel wrote:
> Acked-by: Niklas Cassel <[email protected]>

Hi Nik, This patch has been Acknowledged but is not getting added /
applied to the
respective git source tree. Please let me know if there is any problem.

Thanks
Surender
>
> On 06/27/2017 02:15 PM, [email protected] wrote:
>> From: Surender Polsani <[email protected]>
>>
>> "interrupt-parent" property is declared in root node, so it is global
>> to all nodes. This property is re-declared in few sub-nodes. To avoid
>> duplication this property is removed from following sub-nodes:
>> pmu, amba@0, amba@0/ethernet.
>>
>> Signed-off-by: Surender Polsani <[email protected]>
>> ---
>> arch/arm/boot/dts/artpec6.dtsi | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
>> index 767cbe8..2ed1177 100644
>> --- a/arch/arm/boot/dts/artpec6.dtsi
>> +++ b/arch/arm/boot/dts/artpec6.dtsi
>> @@ -151,7 +151,6 @@
>> interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
>> <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
>> interrupt-affinity = <&cpu0>, <&cpu1>;
>> - interrupt-parent = <&intc>;
>> };
>>
>> pcie: pcie@f8050000 {
>> @@ -185,7 +184,6 @@
>> compatible = "simple-bus";
>> #address-cells = <0x1>;
>> #size-cells = <0x1>;
>> - interrupt-parent = <&intc>;
>> ranges;
>> dma-ranges = <0x80000000 0x00000000 0x40000000>;
>> dma-coherent;
>> @@ -195,7 +193,6 @@
>> clocks = <&eth_phy_ref_clk>,
>> <&clkctrl ARTPEC6_CLK_ETH_ACLK>;
>> compatible = "snps,dwc-qos-ethernet-4.10";
>> - interrupt-parent = <&intc>;
>> interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>> reg = <0xf8010000 0x4000>;
>>
>>

2017-09-04 15:24:01

by Niklas Cassel

[permalink] [raw]
Subject: Re: [PATCH] arm: boot: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes

On 08/11/2017 09:56 AM, Surender Polsani wrote:
> On Tuesday 27 June 2017 05:57 PM, Niklas Cassel wrote:
>> Acked-by: Niklas Cassel <[email protected]>
>
> Hi Nik, This patch has been Acknowledged but is not getting added / applied to the
> respective git source tree. Please let me know if there is any problem.

Hello Surender,

Sorry for the delay.

Could you please resend your patch,
add "To: [email protected]", together with my Ack.

Best regards,
Niklas

>
> Thanks
> Surender
>>
>> On 06/27/2017 02:15 PM, [email protected] wrote:
>>> From: Surender Polsani <[email protected]>
>>>
>>> "interrupt-parent" property is declared in root node, so it is global
>>> to all nodes. This property is re-declared in few sub-nodes. To avoid
>>> duplication this property is removed from following sub-nodes:
>>> pmu, amba@0, amba@0/ethernet.
>>>
>>> Signed-off-by: Surender Polsani <[email protected]>
>>> ---
>>>   arch/arm/boot/dts/artpec6.dtsi | 3 ---
>>>   1 file changed, 3 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
>>> index 767cbe8..2ed1177 100644
>>> --- a/arch/arm/boot/dts/artpec6.dtsi
>>> +++ b/arch/arm/boot/dts/artpec6.dtsi
>>> @@ -151,7 +151,6 @@
>>>           interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
>>>               <GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
>>>           interrupt-affinity = <&cpu0>, <&cpu1>;
>>> -        interrupt-parent = <&intc>;
>>>       };
>>>         pcie: pcie@f8050000 {
>>> @@ -185,7 +184,6 @@
>>>           compatible = "simple-bus";
>>>           #address-cells = <0x1>;
>>>           #size-cells = <0x1>;
>>> -        interrupt-parent = <&intc>;
>>>           ranges;
>>>           dma-ranges = <0x80000000 0x00000000 0x40000000>;
>>>           dma-coherent;
>>> @@ -195,7 +193,6 @@
>>>               clocks = <&eth_phy_ref_clk>,
>>>                   <&clkctrl ARTPEC6_CLK_ETH_ACLK>;
>>>               compatible = "snps,dwc-qos-ethernet-4.10";
>>> -            interrupt-parent = <&intc>;
>>>               interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
>>>               reg = <0xf8010000 0x4000>;
>>>  
>

2017-09-06 05:08:52

by Surender Polsani

[permalink] [raw]
Subject: [PATCH v2] arm: dts: artpec6: Remove unnecessary interrupt-parent property from sub-nodes

From: Surender Polsani <[email protected]>

"interrupt-parent" property is declared in root node, so it is global
to all nodes. This property is re-declared in few sub-nodes. To avoid
duplication this property is removed from following sub-nodes: pmu,
amba@0, amba@0/ethernet.

Signed-off-by: Surender Polsani <[email protected]>
Acked-by: Niklas Cassel <[email protected]>
---
Changes for v2:

- Done few changes as suggested by Niklas Cassel.
- Patch is rebased and built(ARCH=arm) on latest next-20170905.
---
arch/arm/boot/dts/artpec6.dtsi | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm/boot/dts/artpec6.dtsi b/arch/arm/boot/dts/artpec6.dtsi
index 767cbe8..2ed1177 100644
--- a/arch/arm/boot/dts/artpec6.dtsi
+++ b/arch/arm/boot/dts/artpec6.dtsi
@@ -151,7 +151,6 @@
interrupts = <GIC_SPI 0 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 1 IRQ_TYPE_LEVEL_HIGH>;
interrupt-affinity = <&cpu0>, <&cpu1>;
- interrupt-parent = <&intc>;
};

pcie: pcie@f8050000 {
@@ -185,7 +184,6 @@
compatible = "simple-bus";
#address-cells = <0x1>;
#size-cells = <0x1>;
- interrupt-parent = <&intc>;
ranges;
dma-ranges = <0x80000000 0x00000000 0x40000000>;
dma-coherent;
@@ -195,7 +193,6 @@
clocks = <&eth_phy_ref_clk>,
<&clkctrl ARTPEC6_CLK_ETH_ACLK>;
compatible = "snps,dwc-qos-ethernet-4.10";
- interrupt-parent = <&intc>;
interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
reg = <0xf8010000 0x4000>;

--
1.9.1