2017-07-12 08:14:07

by Benjamin Gaignard

Subject: [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions

rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they
rely on 32bits variables and that will make rtc break in y2038/2016.
Stop using those two functions to safer 64bits ones.

Signed-off-by: Benjamin Gaignard <[email protected]>
CC: Michael Chan <[email protected]>
CC: [email protected]
CC: [email protected]
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index b56c54d..9fef202 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -4703,7 +4703,7 @@ int bnxt_hwrm_fw_set_time(struct bnxt *bp)
return -EOPNOTSUPP;

do_gettimeofday(&tv);
- rtc_time_to_tm(tv.tv_sec, &tm);
+ rtc_time64_to_tm(tv.tv_sec, &tm);
bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_FW_SET_TIME, -1, -1);
req.year = cpu_to_le16(1900 + tm.tm_year);
req.month = 1 + tm.tm_mon;
--
1.9.1

2017-07-12 20:01:37

by Michael Chan

Subject: Re: [PATCH v2 03/22] net: broadcom: stop using rtc deprecated functions

On Wed, Jul 12, 2017 at 1:04 AM, Benjamin Gaignard
<[email protected]> wrote:
> rtc_time_to_tm() and rtc_tm_to_time() are deprecated because they
> rely on 32bits variables and that will make rtc break in y2038/2016.
> Stop using those two functions to safer 64bits ones.
>
> Signed-off-by: Benjamin Gaignard <[email protected]>
> CC: Michael Chan <[email protected]>
> CC: [email protected]
> CC: [email protected]

Acked-by: Michael Chan <[email protected]>

Thanks.