2023-06-30 16:40:28

by Karol Herbst

[permalink] [raw]
Subject: [PATCH] drm/nouveau/disp/g94: enable HDMI

Cc: Ben Skeggs <[email protected]>
Cc: Lyude Paul <[email protected]>
Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods")
Signed-off-by: Karol Herbst <[email protected]>
---
drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c
index a4853c4e5ee3..67ef889a0c5f 100644
--- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c
+++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c
@@ -295,6 +295,7 @@ g94_sor = {
.clock = nv50_sor_clock,
.war_2 = g94_sor_war_2,
.war_3 = g94_sor_war_3,
+ .hdmi = &g84_sor_hdmi,
.dp = &g94_sor_dp,
};

--
2.41.0



2023-07-07 21:44:58

by Lyude Paul

[permalink] [raw]
Subject: Re: [PATCH] drm/nouveau/disp/g94: enable HDMI

Reviewed-by: Lyude Paul <[email protected]>

But seeing as I looked at this + some other patches yesterday I assume there's
still more to this?

On Fri, 2023-06-30 at 18:06 +0200, Karol Herbst wrote:
> Cc: Ben Skeggs <[email protected]>
> Cc: Lyude Paul <[email protected]>
> Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods")
> Signed-off-by: Karol Herbst <[email protected]>
> ---
> drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c
> index a4853c4e5ee3..67ef889a0c5f 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c
> @@ -295,6 +295,7 @@ g94_sor = {
> .clock = nv50_sor_clock,
> .war_2 = g94_sor_war_2,
> .war_3 = g94_sor_war_3,
> + .hdmi = &g84_sor_hdmi,
> .dp = &g94_sor_dp,
> };
>

--
Cheers,
Lyude Paul (she/her)
Software Engineer at Red Hat


2023-07-08 00:23:13

by Karol Herbst

[permalink] [raw]
Subject: Re: [PATCH] drm/nouveau/disp/g94: enable HDMI

On Fri, Jul 7, 2023 at 11:03 PM Lyude Paul <[email protected]> wrote:
>
> Reviewed-by: Lyude Paul <[email protected]>
>
> But seeing as I looked at this + some other patches yesterday I assume there's
> still more to this?
>

not really. All those patches are all independent and just a bunch of
fixes. I just figured this one out a bit later.

> On Fri, 2023-06-30 at 18:06 +0200, Karol Herbst wrote:
> > Cc: Ben Skeggs <[email protected]>
> > Cc: Lyude Paul <[email protected]>
> > Fixes: f530bc60a30b ("drm/nouveau/disp: move HDMI config into acquire + infoframe methods")
> > Signed-off-by: Karol Herbst <[email protected]>
> > ---
> > drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c
> > index a4853c4e5ee3..67ef889a0c5f 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/g94.c
> > @@ -295,6 +295,7 @@ g94_sor = {
> > .clock = nv50_sor_clock,
> > .war_2 = g94_sor_war_2,
> > .war_3 = g94_sor_war_3,
> > + .hdmi = &g84_sor_hdmi,
> > .dp = &g94_sor_dp,
> > };
> >
>
> --
> Cheers,
> Lyude Paul (she/her)
> Software Engineer at Red Hat
>