2017-08-03 12:01:06

by Cihangir Akturk

Subject: [PATCH 02/29] drm: mali-dp: switch to drm_*{get,put} helpers

drm_*_reference() and drm_*_unreference() functions are just
compatibility alias for drm_*_get() and drm_*_put() and should not be
used by new code. So convert all users of compatibility functions to use
the new APIs.

Signed-off-by: Cihangir Akturk <[email protected]>
---
drivers/gpu/drm/arm/malidp_planes.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
index 600fa7b..cb71360 100644
--- a/drivers/gpu/drm/arm/malidp_planes.c
+++ b/drivers/gpu/drm/arm/malidp_planes.c
@@ -57,7 +57,7 @@ static void malidp_de_plane_destroy(struct drm_plane *plane)
struct malidp_plane *mp = to_malidp_plane(plane);

if (mp->base.fb)
- drm_framebuffer_unreference(mp->base.fb);
+ drm_framebuffer_put(mp->base.fb);

drm_plane_helper_disable(plane);
drm_plane_cleanup(plane);
--
2.7.4

2017-08-03 14:02:51

by Liviu Dudau

Subject: Re: [PATCH 02/29] drm: mali-dp: switch to drm_*{get,put} helpers

Hi Cihangir,

On Thu, Aug 03, 2017 at 02:58:17PM +0300, Cihangir Akturk wrote:
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() and should not be
> used by new code. So convert all users of compatibility functions to use
> the new APIs.

Thank you for the patch!

>
> Signed-off-by: Cihangir Akturk <[email protected]>

Acked-by: Liviu Dudau <[email protected]>

I will pull the patch and send it to Dave.

Best regards,
Liviu

> ---
> drivers/gpu/drm/arm/malidp_planes.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c
> index 600fa7b..cb71360 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -57,7 +57,7 @@ static void malidp_de_plane_destroy(struct drm_plane *plane)
> struct malidp_plane *mp = to_malidp_plane(plane);
>
> if (mp->base.fb)
> - drm_framebuffer_unreference(mp->base.fb);
> + drm_framebuffer_put(mp->base.fb);
>
> drm_plane_helper_disable(plane);
> drm_plane_cleanup(plane);
> --
> 2.7.4
>

--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯