2017-08-08 15:45:58

by Bhumika Goyal

Subject: [PATCH] staging: vboxvideo: make drm_fb_helper_funcs const

Make the structure const as it is only passed to the function
drm_fb_helper_prepare and the corresponding argument is of type
const.
Done using Coccinelle.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/staging/vboxvideo/vbox_fb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vboxvideo/vbox_fb.c b/drivers/staging/vboxvideo/vbox_fb.c
index bf66358..c386039 100644
--- a/drivers/staging/vboxvideo/vbox_fb.c
+++ b/drivers/staging/vboxvideo/vbox_fb.c
@@ -317,7 +317,7 @@ static int vboxfb_create(struct drm_fb_helper *helper,
return 0;
}

-static struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
+static const struct drm_fb_helper_funcs vbox_fb_helper_funcs = {
.fb_probe = vboxfb_create,
};

--
1.9.1

2017-08-17 17:03:32

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: vboxvideo: make drm_fb_helper_funcs const

On Tue, Aug 08, 2017 at 09:15:42PM +0530, Bhumika Goyal wrote:
> Make the structure const as it is only passed to the function
> drm_fb_helper_prepare and the corresponding argument is of type
> const.
> Done using Coccinelle.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> drivers/staging/vboxvideo/vbox_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Does not apply to my tree at all :(

2017-08-17 17:05:09

by Bhumika Goyal

Subject: Re: [PATCH] staging: vboxvideo: make drm_fb_helper_funcs const

On Thu, Aug 17, 2017 at 10:33 PM, Greg KH <[email protected]> wrote:
> On Tue, Aug 08, 2017 at 09:15:42PM +0530, Bhumika Goyal wrote:
>> Make the structure const as it is only passed to the function
>> drm_fb_helper_prepare and the corresponding argument is of type
>> const.
>> Done using Coccinelle.
>>
>> Signed-off-by: Bhumika Goyal <[email protected]>
>> ---
>> drivers/staging/vboxvideo/vbox_fb.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Does not apply to my tree at all :(

Okay, I will resend it.

Thanks,
Bhumika