2017-08-10 15:15:57

by Anton Vasilyev

[permalink] [raw]

Subject: [PATCH] i2c: use release_mem_region instead of release_resource

---

Use api pair of request_mem_region and release_mem_region
instead of release_resource.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Anton Vasilyev <[email protected]>
---
drivers/i2c/busses/i2c-simtec.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-simtec.c b/drivers/i2c/busses/i2c-simtec.c
index b4685bb..adca51a 100644
--- a/drivers/i2c/busses/i2c-simtec.c
+++ b/drivers/i2c/busses/i2c-simtec.c
@@ -127,8 +127,7 @@ static int simtec_i2c_probe(struct platform_device *dev)
iounmap(pd->reg);

err_res:
- release_resource(pd->ioarea);
- kfree(pd->ioarea);
+ release_mem_region(pd->ioarea->start, size);

err:
kfree(pd);
@@ -142,8 +141,7 @@ static int simtec_i2c_remove(struct platform_device *dev)
i2c_del_adapter(&pd->adap);

iounmap(pd->reg);
- release_resource(pd->ioarea);
- kfree(pd->ioarea);
+ release_mem_region(pd->ioarea->start, resource_size(pd->ioarea));
kfree(pd);

return 0;
--
2.7.4

2017-08-14 19:38:00

by Wolfram Sang

[permalink] [raw]

Subject: Re: [PATCH] i2c: use release_mem_region instead of release_resource

---

On Thu, Aug 10, 2017 at 06:15:45PM +0300, Anton Vasilyev wrote:
> Use api pair of request_mem_region and release_mem_region
> instead of release_resource.
>
> Found by Linux Driver Verification project (linuxtesting.org).
>
> Signed-off-by: Anton Vasilyev <[email protected]>

Applied to for-current, thanks!

---

Attachments:

(No filename) (313.00 B)
signature.asc (833.00 B)
Download all attachments