2017-08-11 10:17:23

by Yinbo Zhu

Subject: [PATCH 3/3] core-arm: add a member about dma_map_ops in dev_archdata struct

From: "yinbo.zhu" <[email protected]>

Signed-off-by: yinbo.zhu <[email protected]>
---
arch/arm/include/asm/device.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h
index 220ba20..c93d3df 100644
--- a/arch/arm/include/asm/device.h
+++ b/arch/arm/include/asm/device.h
@@ -7,6 +7,7 @@
#define ASMARM_DEVICE_H

struct dev_archdata {
+const struct dma_map_ops *dma_ops;
#ifdef CONFIG_DMABOUNCE
struct dmabounce_device_info *dmabounce;
#endif
--
2.1.0.27.g96db324

2017-08-11 16:38:54

by Leo Li

Subject: RE: [linux-devel] [PATCH 3/3] core-arm: add a member about dma_map_ops in dev_archdata struct

> -----Original Message-----
> From: [email protected] [mailto:linux-devel-
> [email protected]] On Behalf Of [email protected]
> Sent: Friday, August 11, 2017 5:01 AM
> To: [email protected]; Yinbo Zhu <[email protected]>; Rob
> Herring <[email protected]>; Mark Rutland <[email protected]>;
> Russell King <[email protected]>; Felipe Balbi <[email protected]>
> Cc: open list <[email protected]>; Laurent Pinchart
> <[email protected]>; Catalin Marinas
> <[email protected]>; open list <[email protected]>; open list
> <[email protected]>; Doug Ledford <[email protected]>;
> Stefano Stabellini <[email protected]>; Greg Kroah-Hartman
> <[email protected]>; Bart Van Assche
> <[email protected]>; moderated list <linux-arm-
> [email protected]>
> Subject: [linux-devel] [PATCH 3/3] core-arm: add a member about
> dma_map_ops in dev_archdata struct
>
> From: "yinbo.zhu" <[email protected]>

The dma_ops was just moved from struct dev_archdata to struct device with commit 5657933dbb6e25feaf5d8df8c88f96cdade693a3. Don't duplicate the dma_ops in both places if you don't have a good reason.

>
> Signed-off-by: yinbo.zhu <[email protected]>
> ---
> arch/arm/include/asm/device.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/include/asm/device.h b/arch/arm/include/asm/device.h
> index 220ba20..c93d3df 100644
> --- a/arch/arm/include/asm/device.h
> +++ b/arch/arm/include/asm/device.h
> @@ -7,6 +7,7 @@
> #define ASMARM_DEVICE_H
>
> struct dev_archdata {
> +const struct dma_map_ops *dma_ops;
> #ifdef CONFIG_DMABOUNCE
> struct dmabounce_device_info *dmabounce; #endif
> --
> 2.1.0.27.g96db324
>
> _______________________________________________
> linux-devel mailing list
> [email protected]
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgforge.
> freescale.net%2Fmailman%2Flistinfo%2Flinux-
> devel&data=01%7C01%7Cleoyang.li%40nxp.com%7Cc83542988dac448bd8b908
> d4e0a230af%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=1pbSjxG781
> yjcCF%2BuXbRCkV6ytbfTTgQkHNWmm0e9nk%3D&reserved=0