2017-08-12 05:40:20

by Jagan Teki

[permalink] [raw]
Subject: [PATCH] arm64: allwinner: a64: pine64: Use dcdc1 regulator for mmc0

From: Jagan Teki <[email protected]>

Since current tree support AXP803 regulators, replace
fixed regulator with AXP803 dcdc1 regulator.

Tested on pine64.

Signed-off-by: Jagan Teki <[email protected]>
---
arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
index 122b5d8..604cdae 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pine64.dts
@@ -62,13 +62,6 @@
chosen {
stdout-path = "serial0:115200n8";
};
-
- reg_vcc3v3: vcc3v3 {
- compatible = "regulator-fixed";
- regulator-name = "vcc3v3";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- };
};

&ehci0 {
@@ -109,7 +102,7 @@
&mmc0 {
pinctrl-names = "default";
pinctrl-0 = <&mmc0_pins>;
- vmmc-supply = <&reg_vcc3v3>;
+ vmmc-supply = <&reg_dcdc1>;
cd-gpios = <&pio 5 6 GPIO_ACTIVE_HIGH>;
cd-inverted;
disable-wp;
--
2.7.4


2017-08-14 10:09:42

by Chen-Yu Tsai

[permalink] [raw]
Subject: Re: [PATCH] arm64: allwinner: a64: pine64: Use dcdc1 regulator for mmc0

Hi,

On Sat, Aug 12, 2017 at 1:40 PM, Jagan Teki <[email protected]> wrote:
> From: Jagan Teki <[email protected]>
>
> Since current tree support AXP803 regulators, replace
> fixed regulator with AXP803 dcdc1 regulator.
>
> Tested on pine64.
>
> Signed-off-by: Jagan Teki <[email protected]>

There was a lot of (heated) discussion [1] around this change. Maxime
stated he would merge a patch with this change but ended up picking
a later version without it. I'll leave this to him when he gets back.

ChenYu

[1] https://www.spinics.net/lists/arm-kernel/msg595419.html

2017-08-21 09:48:29

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH] arm64: allwinner: a64: pine64: Use dcdc1 regulator for mmc0

On Sat, Aug 12, 2017 at 11:10:02AM +0530, Jagan Teki wrote:
> From: Jagan Teki <[email protected]>
>
> Since current tree support AXP803 regulators, replace
> fixed regulator with AXP803 dcdc1 regulator.
>
> Tested on pine64.
>
> Signed-off-by: Jagan Teki <[email protected]>

Applied, thanks!
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


Attachments:
(No filename) (421.00 B)
signature.asc (801.00 B)
Download all attachments