2017-08-17 09:50:03

by Timo Alho

[permalink] [raw]
Subject: [PATCH] firmware: tegra: set drvdata earlier

Subdevices of bpmp, such as bpmp-i2c, require the bpmp device's
drvdata to be set during their probe. Currently this is not always the
case. Fix this by calling platform_set_drvdata() earlier during bpmp's
probe.

Signed-off-by: Timo Alho <[email protected]>
---
drivers/firmware/tegra/bpmp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
index b251795..73ca55b 100644
--- a/drivers/firmware/tegra/bpmp.c
+++ b/drivers/firmware/tegra/bpmp.c
@@ -806,6 +806,8 @@ static int tegra_bpmp_probe(struct platform_device *pdev)

dev_info(&pdev->dev, "firmware: %s\n", tag);

+ platform_set_drvdata(pdev, bpmp);
+
err = of_platform_default_populate(pdev->dev.of_node, NULL, &pdev->dev);
if (err < 0)
goto free_mrq;
@@ -822,8 +824,6 @@ static int tegra_bpmp_probe(struct platform_device *pdev)
if (err < 0)
goto free_mrq;

- platform_set_drvdata(pdev, bpmp);
-
return 0;

free_mrq:
--
2.7.4


2017-08-17 11:08:36

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] firmware: tegra: set drvdata earlier

On Thu, Aug 17, 2017 at 12:49:11PM +0300, Timo Alho wrote:
> Subdevices of bpmp, such as bpmp-i2c, require the bpmp device's
> drvdata to be set during their probe. Currently this is not always the
> case. Fix this by calling platform_set_drvdata() earlier during bpmp's
> probe.
>
> Signed-off-by: Timo Alho <[email protected]>
> ---
> drivers/firmware/tegra/bpmp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Applied to for-4.14/firmware, thanks.

Thierry


Attachments:
(No filename) (476.00 B)
signature.asc (833.00 B)
Download all attachments