2017-08-18 12:51:21

by Janani Sankara Babu

Subject: [PATCH] staging:wlan-ng Fix Multiple line dereference

This patch fixes multiple line dereference warning reported
by checkpatch script.

Signed-off-by: Janani S <[email protected]>
---
drivers/staging/wlan-ng/hfa384x_usb.c | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
index ee5fa86..2746e13 100644
--- a/drivers/staging/wlan-ng/hfa384x_usb.c
+++ b/drivers/staging/wlan-ng/hfa384x_usb.c
@@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
kfree(ctlx);
} else if (mode == DOWAIT) {
struct usbctlx_cmd_completor completor;
+ struct usbctlx_completor *cmplt;

- result =
- hfa384x_usbctlx_complete_sync(hw, ctlx,
- init_cmd_completor(&completor,
- &ctlx->
- inbuf.
- cmdresp,
- &cmd->
- result));
+ cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
+ &cmd->result);
+ result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
}

done:
--
1.9.1

2017-08-20 18:10:51

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging:wlan-ng Fix Multiple line dereference

On Fri, Aug 18, 2017 at 06:16:39PM +0530, Janani S wrote:
> This patch fixes multiple line dereference warning reported
> by checkpatch script.
>
> Signed-off-by: Janani S <[email protected]>
> ---
> drivers/staging/wlan-ng/hfa384x_usb.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c
> index ee5fa86..2746e13 100644
> --- a/drivers/staging/wlan-ng/hfa384x_usb.c
> +++ b/drivers/staging/wlan-ng/hfa384x_usb.c
> @@ -1345,15 +1345,11 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw,
> kfree(ctlx);
> } else if (mode == DOWAIT) {
> struct usbctlx_cmd_completor completor;
> + struct usbctlx_completor *cmplt;
>
> - result =
> - hfa384x_usbctlx_complete_sync(hw, ctlx,
> - init_cmd_completor(&completor,
> - &ctlx->
> - inbuf.
> - cmdresp,
> - &cmd->
> - result));
> + cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp,
> + &cmd->result);
> + result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt);
> }
>
> done:

Someone else sent this same patch right before you did, sorry.

greg k-h