2017-08-22 08:13:49

by Bhumika Goyal

Subject: [PATCH] net: mdio-gpio: make mdiobb_ops const

Make this const as it is only stored in a const field of a
mdiobb_ctrl structure.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/net/phy/mdio-gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
index 7faa79b..4333c6e 100644
--- a/drivers/net/phy/mdio-gpio.c
+++ b/drivers/net/phy/mdio-gpio.c
@@ -116,7 +116,7 @@ static void mdc_set(struct mdiobb_ctrl *ctrl, int what)
gpiod_set_value(bitbang->mdc, what);
}

-static struct mdiobb_ops mdio_gpio_ops = {
+static const struct mdiobb_ops mdio_gpio_ops = {
.owner = THIS_MODULE,
.set_mdc = mdc_set,
.set_mdio_dir = mdio_dir,
--
1.9.1

2017-08-22 13:15:15

by Andrew Lunn

Subject: Re: [PATCH] net: mdio-gpio: make mdiobb_ops const

On Tue, Aug 22, 2017 at 01:43:29PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in a const field of a
> mdiobb_ctrl structure.
>
> Signed-off-by: Bhumika Goyal <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2017-08-22 21:23:32

by David Miller

Subject: Re: [PATCH] net: mdio-gpio: make mdiobb_ops const

From: Bhumika Goyal <[email protected]>
Date: Tue, 22 Aug 2017 13:43:29 +0530

> Make this const as it is only stored in a const field of a
> mdiobb_ctrl structure.
>
> Signed-off-by: Bhumika Goyal <[email protected]>

Applied.