2017-08-22 13:11:31

by Bhumika Goyal

Subject: [PATCH] clk: ti: make clk_ops const

Make these const as they are only stored in the const field of a
clk_init_data structure.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/clk/ti/adpll.c | 2 +-
drivers/clk/ti/apll.c | 2 +-
drivers/clk/ti/fapll.c | 4 ++--
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
index 255cafb..d5c6db4 100644
--- a/drivers/clk/ti/adpll.c
+++ b/drivers/clk/ti/adpll.c
@@ -486,7 +486,7 @@ static u8 ti_adpll_get_parent(struct clk_hw *hw)
return 0;
}

-static struct clk_ops ti_adpll_ops = {
+static const struct clk_ops ti_adpll_ops = {
.prepare = ti_adpll_prepare,
.unprepare = ti_adpll_unprepare,
.is_prepared = ti_adpll_is_prepared,
diff --git a/drivers/clk/ti/apll.c b/drivers/clk/ti/apll.c
index 06f486b..83b148f 100644
--- a/drivers/clk/ti/apll.c
+++ b/drivers/clk/ti/apll.c
@@ -304,7 +304,7 @@ static void omap2_apll_disable(struct clk_hw *hw)
ti_clk_ll_ops->clk_writel(v, &ad->control_reg);
}

-static struct clk_ops omap2_apll_ops = {
+static const struct clk_ops omap2_apll_ops = {
.enable = &omap2_apll_enable,
.disable = &omap2_apll_disable,
.is_enabled = &omap2_apll_is_enabled,
diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
index 66a0d0e..071af44 100644
--- a/drivers/clk/ti/fapll.c
+++ b/drivers/clk/ti/fapll.c
@@ -268,7 +268,7 @@ static int ti_fapll_set_rate(struct clk_hw *hw, unsigned long rate,
return 0;
}

-static struct clk_ops ti_fapll_ops = {
+static const struct clk_ops ti_fapll_ops = {
.enable = ti_fapll_enable,
.disable = ti_fapll_disable,
.is_enabled = ti_fapll_is_enabled,
@@ -478,7 +478,7 @@ static int ti_fapll_synth_set_rate(struct clk_hw *hw, unsigned long rate,
return 0;
}

-static struct clk_ops ti_fapll_synt_ops = {
+static const struct clk_ops ti_fapll_synt_ops = {
.enable = ti_fapll_synth_enable,
.disable = ti_fapll_synth_disable,
.is_enabled = ti_fapll_synth_is_enabled,
--
1.9.1

2017-08-23 09:32:01

by Tero Kristo

Subject: Re: [PATCH] clk: ti: make clk_ops const


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 22/08/17 16:11, Bhumika Goyal wrote:
> Make these const as they are only stored in the const field of a
> clk_init_data structure.
>
> Signed-off-by: Bhumika Goyal <[email protected]>

Looks fine.

Acked-by: Tero Kristo <[email protected]>

> ---
> drivers/clk/ti/adpll.c | 2 +-
> drivers/clk/ti/apll.c | 2 +-
> drivers/clk/ti/fapll.c | 4 ++--
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c
> index 255cafb..d5c6db4 100644
> --- a/drivers/clk/ti/adpll.c
> +++ b/drivers/clk/ti/adpll.c
> @@ -486,7 +486,7 @@ static u8 ti_adpll_get_parent(struct clk_hw *hw)
> return 0;
> }
>
> -static struct clk_ops ti_adpll_ops = {
> +static const struct clk_ops ti_adpll_ops = {
> .prepare = ti_adpll_prepare,
> .unprepare = ti_adpll_unprepare,
> .is_prepared = ti_adpll_is_prepared,
> diff --git a/drivers/clk/ti/apll.c b/drivers/clk/ti/apll.c
> index 06f486b..83b148f 100644
> --- a/drivers/clk/ti/apll.c
> +++ b/drivers/clk/ti/apll.c
> @@ -304,7 +304,7 @@ static void omap2_apll_disable(struct clk_hw *hw)
> ti_clk_ll_ops->clk_writel(v, &ad->control_reg);
> }
>
> -static struct clk_ops omap2_apll_ops = {
> +static const struct clk_ops omap2_apll_ops = {
> .enable = &omap2_apll_enable,
> .disable = &omap2_apll_disable,
> .is_enabled = &omap2_apll_is_enabled,
> diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
> index 66a0d0e..071af44 100644
> --- a/drivers/clk/ti/fapll.c
> +++ b/drivers/clk/ti/fapll.c
> @@ -268,7 +268,7 @@ static int ti_fapll_set_rate(struct clk_hw *hw, unsigned long rate,
> return 0;
> }
>
> -static struct clk_ops ti_fapll_ops = {
> +static const struct clk_ops ti_fapll_ops = {
> .enable = ti_fapll_enable,
> .disable = ti_fapll_disable,
> .is_enabled = ti_fapll_is_enabled,
> @@ -478,7 +478,7 @@ static int ti_fapll_synth_set_rate(struct clk_hw *hw, unsigned long rate,
> return 0;
> }
>
> -static struct clk_ops ti_fapll_synt_ops = {
> +static const struct clk_ops ti_fapll_synt_ops = {
> .enable = ti_fapll_synth_enable,
> .disable = ti_fapll_synth_disable,
> .is_enabled = ti_fapll_synth_is_enabled,
>

2017-08-23 22:53:39

by Stephen Boyd

Subject: Re: [PATCH] clk: ti: make clk_ops const

On 08/22, Bhumika Goyal wrote:
> Make these const as they are only stored in the const field of a
> clk_init_data structure.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---

Applied to clk-next

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project