2017-08-22 13:12:24

by Andy Yan

[permalink] [raw]
Subject: [PATCH v2 1/3] ARM: dts: rockchip: add cpu opp table for rv1108

Add cpu opp table for rv1108 to support frequency
from 408MHZ to 1008MHZ.

Signed-off-by: Andy Yan <[email protected]>

---

Changes in v2:
- switch to operating-points-v2
- split cpu-supply to a separate patch

arch/arm/boot/dts/rv1108.dtsi | 27 +++++++++++++++++++++++++++
1 file changed, 27 insertions(+)

diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
index 064cec3..1b854e1 100644
--- a/arch/arm/boot/dts/rv1108.dtsi
+++ b/arch/arm/boot/dts/rv1108.dtsi
@@ -69,6 +69,33 @@
device_type = "cpu";
compatible = "arm,cortex-a7";
reg = <0xf00>;
+ operating-points-v2 = <&cpu_opp_table>;
+ clocks = <&cru ARMCLK>;
+ };
+ };
+
+ cpu_opp_table: opp_table {
+ compatible = "operating-points-v2";
+
+ opp-408000000 {
+ opp-hz = /bits/ 64 <408000000>;
+ opp-microvolt = <975000>;
+ clock-latency-ns = <40000>;
+ };
+ opp-600000000 {
+ opp-hz = /bits/ 64 <600000000>;
+ opp-microvolt = <975000>;
+ clock-latency-ns = <40000>;
+ };
+ opp-816000000 {
+ opp-hz = /bits/ 64 <816000000>;
+ opp-microvolt = <1025000>;
+ clock-latency-ns = <40000>;
+ };
+ opp-1008000000 {
+ opp-hz = /bits/ 64 <1008000000>;
+ opp-microvolt = <1150000>;
+ clock-latency-ns = <40000>;
};
};

--
2.7.4



2017-08-22 13:13:41

by Andy Yan

[permalink] [raw]
Subject: [PATCH v2 2/3] ARM: dts: rockchip: add cpu power supply for rv1108 evb

The cpu is powered by regulator vdd_core on RV1108 evalution
board. Add it to the cpu dt node.

Signed-off-by: Andy Yan <[email protected]>
---

Changes in v2: None

arch/arm/boot/dts/rv1108-evb.dts | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
index 32fb09a..e517aa3 100644
--- a/arch/arm/boot/dts/rv1108-evb.dts
+++ b/arch/arm/boot/dts/rv1108-evb.dts
@@ -104,6 +104,10 @@
};
};

+&cpu0 {
+ cpu-supply = <&vdd_core>;
+};
+
&i2c0 {
status = "okay";
i2c-scl-rising-time-ns = <275>;
--
2.7.4


2017-08-22 13:15:32

by Andy Yan

[permalink] [raw]
Subject: [PATCH v2 3/3] cpufreq: dt: add support for rockchip rv1108

Add the compatible string to support the generic device tree
cpufreq-dt driver on rockchip rv1108 soc.

Signed-off-by: Andy Yan <[email protected]>
---

Changes in v2: None

drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index 1c26292..2d71c09 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -69,6 +69,7 @@ static const struct of_device_id machines[] __initconst = {
{ .compatible = "renesas,r8a7794", },
{ .compatible = "renesas,sh73a0", },

+ { .compatible = "rockchip,rv1108", },
{ .compatible = "rockchip,rk2928", },
{ .compatible = "rockchip,rk3036", },
{ .compatible = "rockchip,rk3066a", },
--
2.7.4


2017-08-22 13:54:19

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] cpufreq: dt: add support for rockchip rv1108

On Tuesday, August 22, 2017 3:15:22 PM CEST Andy Yan wrote:
> Add the compatible string to support the generic device tree
> cpufreq-dt driver on rockchip rv1108 soc.
>
> Signed-off-by: Andy Yan <[email protected]>

This is a [3/3] in a series, so presumably it depends on something, so I guess
it should be applied along with the thing it depends on. Right?

Thanks,
Rafael

2017-08-22 23:33:46

by Heiko Stübner

[permalink] [raw]
Subject: Re: [PATCH v2 1/3] ARM: dts: rockchip: add cpu opp table for rv1108

Am Dienstag, 22. August 2017, 21:11:55 CEST schrieb Andy Yan:
> Add cpu opp table for rv1108 to support frequency
> from 408MHZ to 1008MHZ.
>
> Signed-off-by: Andy Yan <[email protected]>

applied for 4.14


Thanks
Heiko

2017-08-22 23:34:42

by Heiko Stübner

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] ARM: dts: rockchip: add cpu power supply for rv1108 evb

Am Dienstag, 22. August 2017, 21:13:30 CEST schrieb Andy Yan:
> The cpu is powered by regulator vdd_core on RV1108 evalution
> board. Add it to the cpu dt node.
>
> Signed-off-by: Andy Yan <[email protected]>

applied for 4.14.


Thanks
Heiko

2017-08-23 00:49:39

by Andy Yan

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] cpufreq: dt: add support for rockchip rv1108

Hi Rafael:


On 2017年08月22日 21:44, Rafael J. Wysocki wrote:
> On Tuesday, August 22, 2017 3:15:22 PM CEST Andy Yan wrote:
>> Add the compatible string to support the generic device tree
>> cpufreq-dt driver on rockchip rv1108 soc.
>>
>> Signed-off-by: Andy Yan <[email protected]>
> This is a [3/3] in a series, so presumably it depends on something, so I guess
> it should be applied along with the thing it depends on. Right?

The other two are dts parts [1] [2], they have been taken to
arm-soc by Heiko.
And Heiko also gave a Reviewed-by for this patch in v1[3].

[1] https://patchwork.kernel.org/patch/9915139/
[2] https://patchwork.kernel.org/patch/9915145/
[3] https://patchwork.kernel.org/patch/9911907/
>
> Thanks,
> Rafael
>
>
>
>


2017-08-23 01:08:52

by Rafael J. Wysocki

[permalink] [raw]
Subject: Re: [PATCH v2 3/3] cpufreq: dt: add support for rockchip rv1108

On Wed, Aug 23, 2017 at 2:49 AM, Andy Yan <[email protected]> wrote:
> Hi Rafael:
>
>
> On 2017年08月22日 21:44, Rafael J. Wysocki wrote:
>>
>> On Tuesday, August 22, 2017 3:15:22 PM CEST Andy Yan wrote:
>>>
>>> Add the compatible string to support the generic device tree
>>> cpufreq-dt driver on rockchip rv1108 soc.
>>>
>>> Signed-off-by: Andy Yan <[email protected]>
>>
>> This is a [3/3] in a series, so presumably it depends on something, so I
>> guess
>> it should be applied along with the thing it depends on. Right?
>
>
> The other two are dts parts [1] [2], they have been taken to arm-soc by
> Heiko.
> And Heiko also gave a Reviewed-by for this patch in v1[3].
>
> [1] https://patchwork.kernel.org/patch/9915139/
> [2] https://patchwork.kernel.org/patch/9915145/
> [3] https://patchwork.kernel.org/patch/9911907/

So please ask Viresh for an ACK on this one and route it through
arm-soc as well.

Thanks,
Rafael