2017-08-28 17:32:37

by Bhumika Goyal

Subject: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const

Make this const as it is only passed to a const argument of the function
fpga_bridge_register.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/fpga/xilinx-pr-decoupler.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
index e359930..0d77430 100644
--- a/drivers/fpga/xilinx-pr-decoupler.c
+++ b/drivers/fpga/xilinx-pr-decoupler.c
@@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
return !status;
}

-static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
+static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
.enable_set = xlnx_pr_decoupler_enable_set,
.enable_show = xlnx_pr_decoupler_enable_show,
};
--
1.9.1

2017-08-29 06:00:37

by Michal Simek

Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const

On 28.8.2017 19:32, Bhumika Goyal wrote:
> Make this const as it is only passed to a const argument of the function
> fpga_bridge_register.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> drivers/fpga/xilinx-pr-decoupler.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
> index e359930..0d77430 100644
> --- a/drivers/fpga/xilinx-pr-decoupler.c
> +++ b/drivers/fpga/xilinx-pr-decoupler.c
> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
> return !status;
> }
>
> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
> .enable_set = xlnx_pr_decoupler_enable_set,
> .enable_show = xlnx_pr_decoupler_enable_show,
> };
>

Acked-by: Michal Simek <[email protected]>

Thanks,
Michal

2017-08-29 16:09:53

by Moritz Fischer

Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const

On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <[email protected]> wrote:
> On 28.8.2017 19:32, Bhumika Goyal wrote:
>> Make this const as it is only passed to a const argument of the function
>> fpga_bridge_register.
>>
>> Signed-off-by: Bhumika Goyal <[email protected]>

Acked-by: Moritz Fischer <[email protected]>
>> ---
>> drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>> index e359930..0d77430 100644
>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>> return !status;
>> }
>>
>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>> .enable_set = xlnx_pr_decoupler_enable_set,
>> .enable_show = xlnx_pr_decoupler_enable_show,
>> };

Must've been a leftover from when I worked on integrating a simple
GPIO based one.
I'll have to rebase that and submit it.
>>
>
> Acked-by: Michal Simek <[email protected]>
>
> Thanks,
> Michal
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

Thanks,
Moritz

2017-09-21 14:43:29

by Alan Tull

Subject: Re: [PATCH] fpga: make xlnx_pr_decoupler_br_ops const

On Tue, Aug 29, 2017 at 11:09 AM, Moritz Fischer
<[email protected]> wrote:
> On Tue, Aug 29, 2017 at 12:00 AM, Michal Simek <[email protected]> wrote:
>> On 28.8.2017 19:32, Bhumika Goyal wrote:
>>> Make this const as it is only passed to a const argument of the function
>>> fpga_bridge_register.
>>>
>>> Signed-off-by: Bhumika Goyal <[email protected]>
>
> Acked-by: Moritz Fischer <[email protected]>
>>> ---
>>> drivers/fpga/xilinx-pr-decoupler.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/fpga/xilinx-pr-decoupler.c b/drivers/fpga/xilinx-pr-decoupler.c
>>> index e359930..0d77430 100644
>>> --- a/drivers/fpga/xilinx-pr-decoupler.c
>>> +++ b/drivers/fpga/xilinx-pr-decoupler.c
>>> @@ -79,7 +79,7 @@ static int xlnx_pr_decoupler_enable_show(struct fpga_bridge *bridge)
>>> return !status;
>>> }
>>>
>>> -static struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>> +static const struct fpga_bridge_ops xlnx_pr_decoupler_br_ops = {
>>> .enable_set = xlnx_pr_decoupler_enable_set,
>>> .enable_show = xlnx_pr_decoupler_enable_show,
>>> };
>
> Must've been a leftover from when I worked on integrating a simple
> GPIO based one.
> I'll have to rebase that and submit it.
>>>
>>
>> Acked-by: Michal Simek <[email protected]>
Signed-off-by: Alan Tull <[email protected]>
>>
>> Thanks,
>> Michal
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
>> the body of a message to [email protected]
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
> Thanks,
> Moritz