2017-08-29 18:02:18

by Harsha Sharma

Subject: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

Fixes checkpatch.pl warning: Use WARN_ON() rather than BUG_ON() and BUG()

Signed-off-by: harsha <[email protected]>
---
drivers/staging/android/ion/ion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
index 93e2c90..a2d36b3 100644
--- a/drivers/staging/android/ion/ion.c
+++ b/drivers/staging/android/ion/ion.c
@@ -66,7 +66,7 @@ static void ion_buffer_add(struct ion_device *dev,
p = &(*p)->rb_right;
} else {
pr_err("%s: buffer already found.", __func__);
- BUG();
+ WARN_ON();
}
}

--
1.9.1

2017-08-29 18:07:44

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging:android:ion:ion.c : Using WARN_ON() rather than BUG()

On Tue, Aug 29, 2017 at 11:30:22PM +0530, harsha wrote:
> Fixes checkpatch.pl warning: Use WARN_ON() rather than BUG_ON() and BUG()
>
> Signed-off-by: harsha <[email protected]>

I still need a real name here.

> ---
> drivers/staging/android/ion/ion.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c
> index 93e2c90..a2d36b3 100644
> --- a/drivers/staging/android/ion/ion.c
> +++ b/drivers/staging/android/ion/ion.c
> @@ -66,7 +66,7 @@ static void ion_buffer_add(struct ion_device *dev,
> p = &(*p)->rb_right;
> } else {
> pr_err("%s: buffer already found.", __func__);
> - BUG();
> + WARN_ON();

You can't just change code without understanding _why_ you are changing
it. You just changed the logic here, why do you think it is ok that
BUG() is no longer called? Are you properly cleaning up and recovering
here now that WARN_ON() is called?

checkpatch.pl is a hint, you can't just blindly do whatever it says, you
still have to think.

thanks,

greg k-h