2017-08-30 12:52:41

by Bhumika Goyal

Subject: [PATCH] usbip: vhci-hcd: make vhci_hc_driver const

Make this const as it is not modified anywhere.

Signed-off-by: Bhumika Goyal <[email protected]>
---
drivers/usb/usbip/vhci_hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
index c747623..11b9a22 100644
--- a/drivers/usb/usbip/vhci_hcd.c
+++ b/drivers/usb/usbip/vhci_hcd.c
@@ -1274,7 +1274,7 @@ static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev,
return 0;
}

-static struct hc_driver vhci_hc_driver = {
+static const struct hc_driver vhci_hc_driver = {
.description = driver_name,
.product_desc = driver_desc,
.hcd_priv_size = sizeof(struct vhci_hcd),
--
1.9.1

2017-08-30 17:27:53

by Shuah Khan

Subject: Re: [PATCH] usbip: vhci-hcd: make vhci_hc_driver const

On 08/30/2017 06:52 AM, Bhumika Goyal wrote:
> Make this const as it is not modified anywhere.
>
> Signed-off-by: Bhumika Goyal <[email protected]>
> ---
> drivers/usb/usbip/vhci_hcd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index c747623..11b9a22 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1274,7 +1274,7 @@ static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev,
> return 0;
> }
>
> -static struct hc_driver vhci_hc_driver = {
> +static const struct hc_driver vhci_hc_driver = {
> .description = driver_name,
> .product_desc = driver_desc,
> .hcd_priv_size = sizeof(struct vhci_hcd),
>

Looks good to me.

Acked-by: Shuah Khan <[email protected]>

thanks,
-- Shuah