2017-09-07 20:33:59

by Harsha Sharma

Subject: [PATCH] Staging:pi433:pi433_if.c:Fixes minor typo errors

Fixes checkpatch warning -- "occured" and "succesfully" are misspelled

Signed-off-by: Harsha Sharma <[email protected]>
---
drivers/staging/pi433/pi433_if.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
index 6b9b7df..6a10478 100644
--- a/drivers/staging/pi433/pi433_if.c
+++ b/drivers/staging/pi433/pi433_if.c
@@ -473,7 +473,7 @@ struct pi433_instance {
}


- /* rx done, wait was interrupted or error occured */
+ /* rx done, wait was interrupted or error occurred */
abort:
dev->interrupt_rx_allowed = true;
SET_CHECKED(rf69_set_mode(dev->spi, standby));
@@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device)
if (retval)
return retval;

- dev_dbg(&device->spi->dev, "%s succesfully configured", name);
+ dev_dbg(&device->spi->dev, "%s successfully configured", name);
}

return 0;
--
1.9.1

2017-09-07 21:45:59

by Julia Lawall

Subject: Re: [Outreachy kernel] [PATCH] Staging:pi433:pi433_if.c:Fixes minor typo errors

On Fri, 8 Sep 2017, harsha wrote:

> Fixes checkpatch warning -- "occured" and "succesfully" are misspelled

Thanks for the patch. The change looks ok, but the subject line is not.
Use git log --oneline on the affected file to see what others have done.
In general, you cannot guess what the subject line should be. But in
almost all cases, there is a space after each : and a filename, if it
needs to be included, does not have an extension.

julia

>
> Signed-off-by: Harsha Sharma <[email protected]>
> ---
> drivers/staging/pi433/pi433_if.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/pi433/pi433_if.c b/drivers/staging/pi433/pi433_if.c
> index 6b9b7df..6a10478 100644
> --- a/drivers/staging/pi433/pi433_if.c
> +++ b/drivers/staging/pi433/pi433_if.c
> @@ -473,7 +473,7 @@ struct pi433_instance {
> }
>
>
> - /* rx done, wait was interrupted or error occured */
> + /* rx done, wait was interrupted or error occurred */
> abort:
> dev->interrupt_rx_allowed = true;
> SET_CHECKED(rf69_set_mode(dev->spi, standby));
> @@ -1033,7 +1033,7 @@ static int setup_GPIOs(struct pi433_device *device)
> if (retval)
> return retval;
>
> - dev_dbg(&device->spi->dev, "%s succesfully configured", name);
> + dev_dbg(&device->spi->dev, "%s successfully configured", name);
> }
>
> return 0;
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504816316-9331-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>