2017-09-11 06:30:59

by Suniel Mahesh

Subject: [RESEND PATCH] arm: dts: am33xx: Add spi alias to match SOC schematics

From: Suniel Mahesh <[email protected]>

Linux bus numbers should match the numbers defined by the chip
manufacturer. This patch add's spi aliases to acheive that bus
naming convention.

Signed-off-by: Suniel Mahesh <[email protected]>
Signed-off-by: Karthik Tummala <[email protected]>
Tested-by: Karthik Tummala <[email protected]>
---
Note:
- Patch was compile tested and built(ARCH=arm) on next-20170911.
- Patch was hardware tested on AM335x (McSPI controller) with
spi flash chips.
- No build/run-time issues reported.
- At present bus numbers are represented as spi1 and spi2 in sysfs
instead of spi0 and spi1, as defined in SOC schematics.
- The commit:
"spi: Pick spi bus number from Linux idr or spi alias"
(SHA1:9b61e302210eba55768962f2f11e96bb508c2408)
has introduced bus numbering which happens dynamically either
via Linux IDR or spi alias for master drivers.
- The commit:
"spi: omap: Allocate bus number from spi framework"
(SHA1:b590782afe0a99fca84f451252ed7e2d64b2f155)
is now using spi framework to allocate bus numbers.
---
arch/arm/boot/dts/am33xx.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 7d7ca05..e58fab8 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -36,6 +36,8 @@
phy1 = &usb1_phy;
ethernet0 = &cpsw_emac0;
ethernet1 = &cpsw_emac1;
+ spi0 = &spi0;
+ spi1 = &spi1;
};

cpus {
--
1.9.1

2017-09-19 17:53:19

by Tony Lindgren

Subject: Re: [RESEND PATCH] arm: dts: am33xx: Add spi alias to match SOC schematics

* [email protected] <[email protected]> [170910 23:31]:
> From: Suniel Mahesh <[email protected]>
>
> Linux bus numbers should match the numbers defined by the chip
> manufacturer. This patch add's spi aliases to acheive that bus
> naming convention.

OK applying into omap-for-v4.14/fixes to follow what we do
already for am4372 and dra7.

Regards,

Tony

> Signed-off-by: Suniel Mahesh <[email protected]>
> Signed-off-by: Karthik Tummala <[email protected]>
> Tested-by: Karthik Tummala <[email protected]>
> ---
> Note:
> - Patch was compile tested and built(ARCH=arm) on next-20170911.
> - Patch was hardware tested on AM335x (McSPI controller) with
> spi flash chips.
> - No build/run-time issues reported.
> - At present bus numbers are represented as spi1 and spi2 in sysfs
> instead of spi0 and spi1, as defined in SOC schematics.
> - The commit:
> "spi: Pick spi bus number from Linux idr or spi alias"
> (SHA1:9b61e302210eba55768962f2f11e96bb508c2408)
> has introduced bus numbering which happens dynamically either
> via Linux IDR or spi alias for master drivers.
> - The commit:
> "spi: omap: Allocate bus number from spi framework"
> (SHA1:b590782afe0a99fca84f451252ed7e2d64b2f155)
> is now using spi framework to allocate bus numbers.
> ---
> arch/arm/boot/dts/am33xx.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 7d7ca05..e58fab8 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -36,6 +36,8 @@
> phy1 = &usb1_phy;
> ethernet0 = &cpsw_emac0;
> ethernet1 = &cpsw_emac1;
> + spi0 = &spi0;
> + spi1 = &spi1;
> };
>
> cpus {
> --
> 1.9.1
>