2017-09-14 16:03:54

by Harsha Sharma

Subject: [PATCH] staging: rtl8723bs: Remove unused variable ret

Remove unused variable ret as it is not used anywhere.
Remove multiple blank lines.
Done using following coccinelle semantic patch

@@
type T;
identifier i;
constant C;
@@

(
extern T i;
|
- T i;
<+... when != i
- i = C;
...+>
)

Signed-off-by: Harsha Sharma <[email protected]>
---
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
index ffbb35a..7935dc5 100644
--- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
@@ -2337,10 +2337,6 @@ static int rtw_wx_read32(struct net_device *dev,
u32 data32;
u32 bytes;
u8 *ptmp;
- int ret;
-
-
- ret = 0;
padapter = (struct adapter *)rtw_netdev_priv(dev);
p = &wrqu->data;
len = p->length;
@@ -2352,7 +2348,6 @@ static int rtw_wx_read32(struct net_device *dev,
return -ENOMEM;

if (copy_from_user(ptmp, p->pointer, len)) {
- ret = -EFAULT;
goto exit;
}

@@ -2375,7 +2370,6 @@ static int rtw_wx_read32(struct net_device *dev,
break;
default:
DBG_871X(KERN_INFO "%s: usage> read [bytes],[address(hex)]\n", __func__);
- ret = -EINVAL;
goto exit;
}
DBG_871X(KERN_INFO "%s: addr = 0x%08X data =%s\n", __func__, addr, extra);
--
1.9.1

2017-09-14 16:11:12

by Julia Lawall

Subject: Re: [Outreachy kernel] [PATCH] staging: rtl8723bs: Remove unused variable ret

On Thu, 14 Sep 2017, Harsha Sharma wrote:

> Remove unused variable ret as it is not used anywhere.
> Remove multiple blank lines.
> Done using following coccinelle semantic patch
>
> @@
> type T;
> identifier i;
> constant C;
> @@
>
> (
> extern T i;
> |
> - T i;
> <+... when != i
> - i = C;
> ...+>
> )
>
> Signed-off-by: Harsha Sharma <[email protected]>
> ---
> drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> index ffbb35a..7935dc5 100644
> --- a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> +++ b/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
> @@ -2337,10 +2337,6 @@ static int rtw_wx_read32(struct net_device *dev,
> u32 data32;
> u32 bytes;
> u8 *ptmp;
> - int ret;
> -
> -
> - ret = 0;
> padapter = (struct adapter *)rtw_netdev_priv(dev);
> p = &wrqu->data;
> len = p->length;
> @@ -2352,7 +2348,6 @@ static int rtw_wx_read32(struct net_device *dev,
> return -ENOMEM;
>
> if (copy_from_user(ptmp, p->pointer, len)) {
> - ret = -EFAULT;
> goto exit;
> }
>
> @@ -2375,7 +2370,6 @@ static int rtw_wx_read32(struct net_device *dev,
> break;
> default:
> DBG_871X(KERN_INFO "%s: usage> read [bytes],[address(hex)]\n", __func__);
> - ret = -EINVAL;
> goto exit;

One could have the impression that the function should instead return ret.
One would have to figure out where the function is called from and what
happens there to the return value.

julia

> }
> DBG_871X(KERN_INFO "%s: addr = 0x%08X data =%s\n", __func__, addr, extra);
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
> To post to this group, send email to [email protected].
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1505404910-11548-1-git-send-email-harshasharmaiitr%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>