2017-09-19 11:14:49

by Bhumika Goyal

Subject: [PATCH] ALSA: hrtimer: make hrtimer_hw const and __initconst

Make this const as it is only used during a copy operation. Also, make
it __initconst as it is only used during the init phase and after this
it is not referenced anywhere.

Signed-off-by: Bhumika Goyal <[email protected]>
---
sound/core/hrtimer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/hrtimer.c b/sound/core/hrtimer.c
index 1ac0c42..5603e49 100644
--- a/sound/core/hrtimer.c
+++ b/sound/core/hrtimer.c
@@ -127,7 +127,7 @@ static int snd_hrtimer_stop(struct snd_timer *t)
return 0;
}

-static struct snd_timer_hardware hrtimer_hw = {
+static const struct snd_timer_hardware hrtimer_hw __initconst = {
.flags = SNDRV_TIMER_HW_AUTO | SNDRV_TIMER_HW_TASKLET,
.open = snd_hrtimer_open,
.close = snd_hrtimer_close,
--
1.9.1

2017-09-19 20:06:28

by Takashi Iwai

Subject: Re: [PATCH] ALSA: hrtimer: make hrtimer_hw const and __initconst

On Tue, 19 Sep 2017 13:14:38 +0200,
Bhumika Goyal wrote:
>
> Make this const as it is only used during a copy operation. Also, make
> it __initconst as it is only used during the init phase and after this
> it is not referenced anywhere.
>
> Signed-off-by: Bhumika Goyal <[email protected]>

Applied, thanks.


Takashi