2017-09-11 16:03:21

by Colin King

[permalink] [raw]
Subject: [PATCH] IB/core: fix incorrect fall-through on switch statement

From: Colin Ian King <[email protected]>

In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and
add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN
however the case OCRDMA_MBX_STATUS_FAILED is missing a break and
falls through to the default case which then re-assigns err_num
to -EFAULT. Fix this so that err_num is assigned to -EAGAIN
for the add_status OCRDMA_MBX_STATUS_FAILED case and -EFAULT
otherwise.

Detected by CoverityScan CID#703125 ("Missing break in switch")

Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter")
Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
index dcb5942f9fb5..65b166cc7437 100644
--- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
+++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
@@ -252,7 +252,10 @@ static int ocrdma_get_mbx_errno(u32 status)
case OCRDMA_MBX_ADDI_STATUS_INSUFFICIENT_RESOURCES:
err_num = -EAGAIN;
break;
+ default:
+ err_num = -EFAULT;
}
+ break;
default:
err_num = -EFAULT;
}
--
2.14.1


2017-09-13 16:49:21

by Leon Romanovsky

[permalink] [raw]
Subject: Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

On Mon, Sep 11, 2017 at 05:03:13PM +0100, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and
> add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN
> however the case OCRDMA_MBX_STATUS_FAILED is missing a break and
> falls through to the default case which then re-assigns err_num
> to -EFAULT. Fix this so that err_num is assigned to -EAGAIN
> for the add_status OCRDMA_MBX_STATUS_FAILED case and -EFAULT
> otherwise.
>
> Detected by CoverityScan CID#703125 ("Missing break in switch")
>
> Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++
> 1 file changed, 3 insertions(+)
>

Except the wrong title: IB/core -> IB/ocrdma

Reviewed-by: Leon Romanovsky <[email protected]>
Thanks

Attachments:
(No filename) (937.00 B)
 signature.asc (833.00 B)
 Download all attachments

2017-09-22 17:16:35

by Doug Ledford

[permalink] [raw]
Subject: Re: [PATCH] IB/core: fix incorrect fall-through on switch statement

On Wed, 2017-09-13 at 19:49 +0300, Leon Romanovsky wrote:
> On Mon, Sep 11, 2017 at 05:03:13PM +0100, Colin King wrote:
> > From: Colin Ian King <[email protected]>
> >
> > In the case where mbox_status is OCRDMA_MBX_STATUS_FAILED and
> > add_status is OCRDMA_MBX_STATUS_FAILED err_num is assigned -EAGAIN
> > however the case OCRDMA_MBX_STATUS_FAILED is missing a break and
> > falls through to the default case which then re-assigns err_num
> > to -EFAULT. Fix this so that err_num is assigned to -EAGAIN
> > for the add_status OCRDMA_MBX_STATUS_FAILED case and -EFAULT
> > otherwise.
> >
> > Detected by CoverityScan CID#703125 ("Missing break in switch")
> >
> > Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect
> > IBoE RDMA adapter")
> > Signed-off-by: Colin Ian King <[email protected]>
> > ---
> > drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
>
> Except the wrong title: IB/core -> IB/ocrdma
>
> Reviewed-by: Leon Romanovsky <[email protected]>

Thanks, patch (with fixed subject) applied.

--
Doug Ledford <[email protected]>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD