2017-09-25 08:17:49

by Arvind Yadav

Subject: [PATCH 0/3] clocksource: pr_err() strings should end with newlines

pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Arvind Yadav (3):
[PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines
[PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
[PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines

drivers/clocksource/owl-timer.c | 4 ++--
drivers/clocksource/rockchip_timer.c | 2 +-
drivers/clocksource/timer-fttmr010.c | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)

--
1.9.1

2017-09-25 08:17:54

by Arvind Yadav

Subject: [PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines

pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/clocksource/timer-fttmr010.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/timer-fttmr010.c b/drivers/clocksource/timer-fttmr010.c
index 66dd909..32214eb 100644
--- a/drivers/clocksource/timer-fttmr010.c
+++ b/drivers/clocksource/timer-fttmr010.c
@@ -263,14 +263,14 @@ static int __init fttmr010_common_init(struct device_node *np, bool is_aspeed)

fttmr010->base = of_iomap(np, 0);
if (!fttmr010->base) {
- pr_err("Can't remap registers");
+ pr_err("Can't remap registers\n");
ret = -ENXIO;
goto out_free;
}
/* IRQ for timer 1 */
irq = irq_of_parse_and_map(np, 0);
if (irq <= 0) {
- pr_err("Can't parse IRQ");
+ pr_err("Can't parse IRQ\n");
ret = -EINVAL;
goto out_unmap;
}
--
1.9.1

2017-09-25 08:17:58

by Arvind Yadav

Subject: [PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines

pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/clocksource/rockchip_timer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/rockchip_timer.c b/drivers/clocksource/rockchip_timer.c
index c27f4c8..33f370d 100644
--- a/drivers/clocksource/rockchip_timer.c
+++ b/drivers/clocksource/rockchip_timer.c
@@ -274,7 +274,7 @@ static int __init rk_clksrc_init(struct device_node *np)
TIMER_NAME, rk_clksrc->freq, 250, 32,
clocksource_mmio_readl_down);
if (ret) {
- pr_err("Failed to register clocksource");
+ pr_err("Failed to register clocksource\n");
goto out_clocksource;
}

--
1.9.1

2017-09-25 08:19:13

by Arvind Yadav

Subject: [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines

pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/clocksource/owl-timer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clocksource/owl-timer.c b/drivers/clocksource/owl-timer.c
index d19c53c..c686305 100644
--- a/drivers/clocksource/owl-timer.c
+++ b/drivers/clocksource/owl-timer.c
@@ -125,7 +125,7 @@ static int __init owl_timer_init(struct device_node *node)

owl_timer_base = of_io_request_and_map(node, 0, "owl-timer");
if (IS_ERR(owl_timer_base)) {
- pr_err("Can't map timer registers");
+ pr_err("Can't map timer registers\n");
return PTR_ERR(owl_timer_base);
}

@@ -134,7 +134,7 @@ static int __init owl_timer_init(struct device_node *node)

timer1_irq = of_irq_get_byname(node, "timer1");
if (timer1_irq <= 0) {
- pr_err("Can't parse timer1 IRQ");
+ pr_err("Can't parse timer1 IRQ\n");
return -EINVAL;
}

--
1.9.1

2017-09-25 08:45:41

by Andreas Färber

Subject: Re: [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines

Am 25.09.2017 um 10:16 schrieb Arvind Yadav:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/clocksource/owl-timer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Andreas Färber <[email protected]>

Regards,
Andreas

--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

2017-09-25 23:35:24

by Daniel Lezcano

Subject: Re: [PATCH 0/3] clocksource: pr_err() strings should end with newlines

On 25/09/2017 10:16, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Arvind Yadav (3):
> [PATCH 1/3] clocksource: fttmr010: pr_err() strings should end with newlines
> [PATCH 2/3] clocksource: owl: pr_err() strings should end with newlines
> [PATCH 3/3] clocksource: rockchip: pr_err() strings should end with newlines
>
> drivers/clocksource/owl-timer.c | 4 ++--
> drivers/clocksource/rockchip_timer.c | 2 +-
> drivers/clocksource/timer-fttmr010.c | 4 ++--
> 3 files changed, 5 insertions(+), 5 deletions(-)

Applied and slightly changed the commit log to:

pr_err() messages should end with a new-line to avoid other messages
being concatenated.

In the future, please use the subject subsystem format to:

clocksource/drivers/<timer>: ....

Thanks.

-- Daniel

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog