2017-11-05 14:32:51

by Pan Bian

[permalink] [raw]
Subject: [PATCH] scsi: advansys: fix improper function call to kfree

In function advansys_eisa_probe(), data->host[i] holds the return value
of scsi_host_alloc(). The memory allocated by scsi_host_alloc() should
be deallocated with scsi_host_put(), not kfree().

Signed-off-by: Pan Bian <[email protected]>
---
drivers/scsi/advansys.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c
index 24e57e7..1f56a6d 100644
--- a/drivers/scsi/advansys.c
+++ b/drivers/scsi/advansys.c
@@ -11678,8 +11678,8 @@ static int advansys_eisa_probe(struct device *dev)
return 0;

free_data:
- kfree(data->host[0]);
- kfree(data->host[1]);
+ scsi_host_put(data->host[0]);
+ scsi_host_put(data->host[1]);
kfree(data);
fail:
return err;
--
1.9.1



From 1583272878739149813@xxx Mon Nov 06 00:04:40 +0000 2017
X-GM-THRID: 1578978461285776164
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread