2017-11-08 17:27:23

by Marcus Wolf

[permalink] [raw]
Subject: [PATCH] Fixes issue with bit shift in rf69_get_modulation

Fixes issue with bit shift in rf69_get_modulation

Signed-off-by: Marcus Wolf <[email protected]>
---
drivers/staging/pi433/rf69.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 290b419..c945b4b 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/drivers/staging/pi433/rf69.c
@@ -102,7 +102,7 @@ enum modulation rf69_get_modulation(struct spi_device *spi)

currentValue = READ_REG(REG_DATAMODUL);

- switch (currentValue & MASK_DATAMODUL_MODULATION_TYPE >> 3) { // TODO improvement: change 3 to define
+ switch (currentValue & MASK_DATAMODUL_MODULATION_TYPE) {
case DATAMODUL_MODULATION_TYPE_OOK: return OOK;
case DATAMODUL_MODULATION_TYPE_FSK: return FSK;
default: return undefined;
--
1.7.10.4


From 1583513155504077719@xxx Wed Nov 08 15:43:46 +0000 2017
X-GM-THRID: 1583056876682661107
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread