2023-01-18 13:15:32

by Johan Jonker

Subject: [PATCH v1 2/4] gpio: gpio-rockchip: add compatible string per SoC

Currently all Rockchip gpio nodes have the same compatible.
Replace all the compatibles in gpio nodes to be able to
give them a consistent ID independent from probe order or alias.

Signed-off-by: Johan Jonker <[email protected]>
---

For now only add new compatibles.
No changes to rockchip_gpio_probe() function yet.
---
drivers/gpio/gpio-rockchip.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
index e5de15a2a..493207de1 100644
--- a/drivers/gpio/gpio-rockchip.c
+++ b/drivers/gpio/gpio-rockchip.c
@@ -790,7 +790,22 @@ static int rockchip_gpio_remove(struct platform_device *pdev)

static const struct of_device_id rockchip_gpio_match[] = {
{ .compatible = "rockchip,gpio-bank", },
+ { .compatible = "rockchip,px30-gpio-bank", },
+ { .compatible = "rockchip,rk3036-gpio-bank", },
+ { .compatible = "rockchip,rk3066a-gpio-bank", },
+ { .compatible = "rockchip,rk3128-gpio-bank", },
+ { .compatible = "rockchip,rk3188-gpio-bank", },
{ .compatible = "rockchip,rk3188-gpio-bank0" },
+ { .compatible = "rockchip,rk3228-gpio-bank", },
+ { .compatible = "rockchip,rk3288-gpio-bank", },
+ { .compatible = "rockchip,rk3328-gpio-bank", },
+ { .compatible = "rockchip,rk3308-gpio-bank", },
+ { .compatible = "rockchip,rk3368-gpio-bank", },
+ { .compatible = "rockchip,rk3399-gpio-bank", },
+ { .compatible = "rockchip,rk3568-gpio-bank", },
+ { .compatible = "rockchip,rk3588-gpio-bank", },
+ { .compatible = "rockchip,rv1108-gpio-bank", },
+ { .compatible = "rockchip,rv1126-gpio-bank", },
{ },
};

--
2.20.1

2023-01-18 14:51:41

by Bartosz Golaszewski

Subject: Re: [PATCH v1 2/4] gpio: gpio-rockchip: add compatible string per SoC

On Wed, Jan 18, 2023 at 1:14 PM Johan Jonker <[email protected]> wrote:
>
> Currently all Rockchip gpio nodes have the same compatible.
> Replace all the compatibles in gpio nodes to be able to
> give them a consistent ID independent from probe order or alias.
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
>
> For now only add new compatibles.
> No changes to rockchip_gpio_probe() function yet.
> ---
> drivers/gpio/gpio-rockchip.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index e5de15a2a..493207de1 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -790,7 +790,22 @@ static int rockchip_gpio_remove(struct platform_device *pdev)
>
> static const struct of_device_id rockchip_gpio_match[] = {
> { .compatible = "rockchip,gpio-bank", },
> + { .compatible = "rockchip,px30-gpio-bank", },
> + { .compatible = "rockchip,rk3036-gpio-bank", },
> + { .compatible = "rockchip,rk3066a-gpio-bank", },
> + { .compatible = "rockchip,rk3128-gpio-bank", },
> + { .compatible = "rockchip,rk3188-gpio-bank", },
> { .compatible = "rockchip,rk3188-gpio-bank0" },
> + { .compatible = "rockchip,rk3228-gpio-bank", },
> + { .compatible = "rockchip,rk3288-gpio-bank", },
> + { .compatible = "rockchip,rk3328-gpio-bank", },
> + { .compatible = "rockchip,rk3308-gpio-bank", },
> + { .compatible = "rockchip,rk3368-gpio-bank", },
> + { .compatible = "rockchip,rk3399-gpio-bank", },
> + { .compatible = "rockchip,rk3568-gpio-bank", },
> + { .compatible = "rockchip,rk3588-gpio-bank", },
> + { .compatible = "rockchip,rv1108-gpio-bank", },
> + { .compatible = "rockchip,rv1126-gpio-bank", },
> { },
> };
>
> --
> 2.20.1
>

If they don't have any additional data associated with each compatible
- why not just use "rockchip,gpio-bank" as the fallback in DT?

Bart

2023-01-18 16:21:25

by Krzysztof Kozlowski

Subject: Re: [PATCH v1 2/4] gpio: gpio-rockchip: add compatible string per SoC

On 18/01/2023 13:14, Johan Jonker wrote:
> Currently all Rockchip gpio nodes have the same compatible.
> Replace all the compatibles in gpio nodes to be able to
> give them a consistent ID independent from probe order or alias.
>
> Signed-off-by: Johan Jonker <[email protected]>
> ---
>
> For now only add new compatibles.
> No changes to rockchip_gpio_probe() function yet.
> ---
> drivers/gpio/gpio-rockchip.c | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c
> index e5de15a2a..493207de1 100644
> --- a/drivers/gpio/gpio-rockchip.c
> +++ b/drivers/gpio/gpio-rockchip.c
> @@ -790,7 +790,22 @@ static int rockchip_gpio_remove(struct platform_device *pdev)
>
> static const struct of_device_id rockchip_gpio_match[] = {
> { .compatible = "rockchip,gpio-bank", },
> + { .compatible = "rockchip,px30-gpio-bank", },
> + { .compatible = "rockchip,rk3036-gpio-bank", },
> + { .compatible = "rockchip,rk3066a-gpio-bank", },
> + { .compatible = "rockchip,rk3128-gpio-bank", },
> + { .compatible = "rockchip,rk3188-gpio-bank", },
> { .compatible = "rockchip,rk3188-gpio-bank0" },
> + { .compatible = "rockchip,rk3228-gpio-bank", },
> + { .compatible = "rockchip,rk3288-gpio-bank", },
> + { .compatible = "rockchip,rk3328-gpio-bank", },
> + { .compatible = "rockchip,rk3308-gpio-bank", },
> + { .compatible = "rockchip,rk3368-gpio-bank", },
> + { .compatible = "rockchip,rk3399-gpio-bank", },
> + { .compatible = "rockchip,rk3568-gpio-bank", },
> + { .compatible = "rockchip,rk3588-gpio-bank", },
> + { .compatible = "rockchip,rv1108-gpio-bank", },
> + { .compatible = "rockchip,rv1126-gpio-bank", },

No, this list is useless. Entire patch should be dropped. Just use fallback.


Best regards,
Krzysztof