2017-12-04 19:52:50

by Gary R Hook

Subject: [PATCH] iommu/amd - Record more information about unknown events

When an unknown type event occurs, the default information written to
the syslog should dump raw event data. This could provide insight into
the event that occurred.

Signed-off-by: Gary R Hook <[email protected]>
---
drivers/iommu/amd_iommu.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
index 51f8215877f5..cb78933ef53f 100644
--- a/drivers/iommu/amd_iommu.c
+++ b/drivers/iommu/amd_iommu.c
@@ -617,7 +617,9 @@ static void iommu_print_event(struct amd_iommu *iommu, void *__evt)
address, flags);
break;
default:
- printk(KERN_ERR "UNKNOWN type=0x%02x]\n", type);
+ printk(KERN_ERR "UNKNOWN type=0x%02x event[0]=0x%08x "
+ "event[1]=0x%08x event[2]=0x%08x event[3]=0x%08x\n",
+ type, event[0], event[1], event[2], event[3]);
}

memset(__evt, 0, 4 * sizeof(u32));

2017-12-20 19:03:01

by Alex Williamson

Subject: Re: [PATCH] iommu/amd - Record more information about unknown events

On Mon, 04 Dec 2017 13:52:42 -0600
Gary R Hook <[email protected]> wrote:

> When an unknown type event occurs, the default information written to
> the syslog should dump raw event data. This could provide insight into
> the event that occurred.
>
> Signed-off-by: Gary R Hook <[email protected]>
> ---
> drivers/iommu/amd_iommu.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)

Applied to v4.16-iommu/amd. Thanks,

Alex