2017-12-06 17:01:05

by Pravin Shedge

[permalink] [raw]
Subject: [PATCH 15/45] drivers: pnp: remove duplicate includes

These duplicate includes have been found with scripts/checkincludes.pl but
they have been removed manually to avoid removing false positives.

Signed-off-by: Pravin Shedge <[email protected]>
---
drivers/pnp/quirks.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
index f054cdd..a0f9a91 100644
--- a/drivers/pnp/quirks.c
+++ b/drivers/pnp/quirks.c
@@ -227,8 +227,6 @@ static void quirk_ad1815_mpu_resources(struct pnp_dev *dev)
dev_info(&dev->dev, "made independent IRQ optional\n");
}

-#include <linux/pci.h>
-
static void quirk_system_pci_resources(struct pnp_dev *dev)
{
struct pci_dev *pdev = NULL;
--
2.7.4


2017-12-08 00:37:18

by Wysocki, Rafael J

[permalink] [raw]
Subject: Re: [PATCH 15/45] drivers: pnp: remove duplicate includes

On 12/6/2017 6:00 PM, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge <[email protected]>

Acked-by: Rafael J. Wysocki <[email protected]>

Or do you want me to apply this?

> ---
> drivers/pnp/quirks.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pnp/quirks.c b/drivers/pnp/quirks.c
> index f054cdd..a0f9a91 100644
> --- a/drivers/pnp/quirks.c
> +++ b/drivers/pnp/quirks.c
> @@ -227,8 +227,6 @@ static void quirk_ad1815_mpu_resources(struct pnp_dev *dev)
> dev_info(&dev->dev, "made independent IRQ optional\n");
> }
>
> -#include <linux/pci.h>
> -
> static void quirk_system_pci_resources(struct pnp_dev *dev)
> {
> struct pci_dev *pdev = NULL;