2017-12-09 11:11:19

by Neil Singh

Subject: [PATCH v2 0/2] staging: rtl8712: Cleanup codestyle

Cleanup some codestyle issues identified by checkpatch.

Changes since v1:
- Split single patch into multiple

Neil Singh (2):
staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE
staging: rtl8712: Cleanup checkpatch issues CODE_INDENT and
LEADING_SPACE

drivers/staging/rtl8712/rtl871x_security.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

--
2.1.4

2017-12-09 11:11:26

by Neil Singh

Subject: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE

Cleanup below checkpatch issue:

WARNING:LONG_LINE: line over 80 characters
1000: FILE: rtl871x_security.c:1000:
+static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,

Signed-off-by: Neil Singh <[email protected]>
---
drivers/staging/rtl8712/rtl871x_security.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
index 56d36f6..77a5f5d 100644
--- a/drivers/staging/rtl8712/rtl871x_security.c
+++ b/drivers/staging/rtl8712/rtl871x_security.c
@@ -997,7 +997,8 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, sint a4_exists,
/* Builds the last MIC header block from */
/* header fields. */
/************************************************/
-static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
+static void construct_ctr_preload(u8 *ctr_preload,
+ sint a4_exists, sint qc_exists,
u8 *mpdu, u8 *pn_vector, sint c)
{
sint i;
--
2.1.4

2017-12-09 11:11:39

by Neil Singh

Subject: [PATCH v2 2/2] staging: rtl8712: Cleanup checkpatch issues CODE_INDENT and LEADING_SPACE

Cleanup below checkpatch issues:

ERROR:CODE_INDENT: code indent should use tabs where possible
1409: FILE: rtl871x_security.c:1409:
+ from_timer(padapter, t, securitypriv.tkip_timer);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
1409: FILE: rtl871x_security.c:1409:
+ from_timer(padapter, t, securitypriv.tkip_timer);$

Signed-off-by: Neil Singh <[email protected]>
---
drivers/staging/rtl8712/rtl871x_security.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
index 77a5f5d..2fd49c0 100644
--- a/drivers/staging/rtl8712/rtl871x_security.c
+++ b/drivers/staging/rtl8712/rtl871x_security.c
@@ -1406,7 +1406,7 @@ u32 r8712_aes_decrypt(struct _adapter *padapter, u8 *precvframe)
void r8712_use_tkipkey_handler(struct timer_list *t)
{
struct _adapter *padapter =
- from_timer(padapter, t, securitypriv.tkip_timer);
+ from_timer(padapter, t, securitypriv.tkip_timer);

padapter->securitypriv.busetkipkey = true;
}
--
2.1.4

2017-12-10 02:27:13

by Larry Finger

Subject: Re: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE

On 12/09/2017 05:11 AM, Neil Singh wrote:
> Cleanup below checkpatch issue:
>
> WARNING:LONG_LINE: line over 80 characters
> 1000: FILE: rtl871x_security.c:1000:
> +static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
>
> Signed-off-by: Neil Singh <[email protected]>
> ---
> drivers/staging/rtl8712/rtl871x_security.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_security.c b/drivers/staging/rtl8712/rtl871x_security.c
> index 56d36f6..77a5f5d 100644
> --- a/drivers/staging/rtl8712/rtl871x_security.c
> +++ b/drivers/staging/rtl8712/rtl871x_security.c
> @@ -997,7 +997,8 @@ static void construct_mic_header2(u8 *mic_header2, u8 *mpdu, sint a4_exists,
> /* Builds the last MIC header block from */
> /* header fields. */
> /************************************************/
> -static void construct_ctr_preload(u8 *ctr_preload, sint a4_exists, sint qc_exists,
> +static void construct_ctr_preload(u8 *ctr_preload,
> + sint a4_exists, sint qc_exists,
> u8 *mpdu, u8 *pn_vector, sint c)
> {
> sint i;
>

Did you run checkpatch on these patches? My system reports the following:

-------
patch_1
-------
WARNING: A patch subject line should describe the change not the tool that found it
#95:
Subject: [PATCH v2 1/2] staging: rtl8712: Cleanup checkpatch issue WARNING:LONG_LINE

CHECK: Alignment should match open parenthesis
#125: FILE: drivers/staging/rtl8712/rtl871x_security.c:1001:
+static void construct_ctr_preload(u8 *ctr_preload,
+ sint a4_exists, sint qc_exists,

-------
patch_2
-------
WARNING: A patch subject line should describe the change not the tool that found it
#95:
Subject: [PATCH v2 2/2] staging: rtl8712: Cleanup checkpatch issues CODE_INDENT
and LEADING_SPACE

Larry