2017-12-22 14:24:17

by Sumit Pundir

Subject: [PATCH] Staging: vt6656: fix unnecessary parantheses

This patch fixes a coding style issue as noted by
checkpatch.pl related to unnecessary parentheses.

This patch fixes the following checkpatch.pl warning:

WARNING: Unnecessary parentheses around 'priv->basic_rates'.

Signed-off-by: Sumit Pundir <[email protected]>
---
drivers/staging/vt6656/card.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
index 501f482..811602e 100644
--- a/drivers/staging/vt6656/card.c
+++ b/drivers/staging/vt6656/card.c
@@ -443,7 +443,7 @@ int vnt_ofdm_min_rate(struct vnt_private *priv)
int ii;

for (ii = RATE_54M; ii >= RATE_6M; ii--) {
- if ((priv->basic_rates) & ((u16)BIT(ii)))
+ if (priv->basic_rates & ((u16)BIT(ii)))
return true;
}

--
2.7.4

2018-01-08 15:44:23

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: vt6656: fix unnecessary parantheses

On Fri, Dec 22, 2017 at 07:53:52PM +0530, Sumit Pundir wrote:
> This patch fixes a coding style issue as noted by
> checkpatch.pl related to unnecessary parentheses.
>
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: Unnecessary parentheses around 'priv->basic_rates'.
>
> Signed-off-by: Sumit Pundir <[email protected]>
> ---
> drivers/staging/vt6656/card.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6656/card.c b/drivers/staging/vt6656/card.c
> index 501f482..811602e 100644
> --- a/drivers/staging/vt6656/card.c
> +++ b/drivers/staging/vt6656/card.c
> @@ -443,7 +443,7 @@ int vnt_ofdm_min_rate(struct vnt_private *priv)
> int ii;
>
> for (ii = RATE_54M; ii >= RATE_6M; ii--) {
> - if ((priv->basic_rates) & ((u16)BIT(ii)))
> + if (priv->basic_rates & ((u16)BIT(ii)))

You still have one too many () around the BIT stuff...