Selecting RESET_CONTROLLER is actually required, otherwise we
can get a link failure in the clock driver:
drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
Cc: <[email protected]> # v5.4
Signed-off-by: Arnd Bergmann <[email protected]>
---
arch/arm/mach-davinci/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
index dd427bd2768c..02b180ad7245 100644
--- a/arch/arm/mach-davinci/Kconfig
+++ b/arch/arm/mach-davinci/Kconfig
@@ -9,6 +9,7 @@ menuconfig ARCH_DAVINCI
select PM_GENERIC_DOMAINS if PM
select PM_GENERIC_DOMAINS_OF if PM && OF
select REGMAP_MMIO
+ select RESET_CONTROLLER
select HAVE_IDE
select PINCTRL_SINGLE
--
2.20.0
wt., 10 gru 2019 o 20:52 Arnd Bergmann <[email protected]> napisał(a):
>
> Selecting RESET_CONTROLLER is actually required, otherwise we
> can get a link failure in the clock driver:
>
> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Cc: <[email protected]> # v5.4
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> arch/arm/mach-davinci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Bartosz Golaszewski <[email protected]>
On Wed, 2019-12-11 at 10:14 +0100, Bartosz Golaszewski wrote:
> wt., 10 gru 2019 o 20:52 Arnd Bergmann <[email protected]> napisał(a):
> > Selecting RESET_CONTROLLER is actually required, otherwise we
> > can get a link failure in the clock driver:
> >
> > drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> > psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> > drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> > psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
> >
> > Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> > Cc: <[email protected]> # v5.4
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > ---
> > arch/arm/mach-davinci/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
>
> Reviewed-by: Bartosz Golaszewski <[email protected]>
Reviewed-by: Philipp Zabel <[email protected]>
regards
Philipp
Hi Arnd,
On 11/12/19 1:21 AM, Arnd Bergmann wrote:
> Selecting RESET_CONTROLLER is actually required, otherwise we
> can get a link failure in the clock driver:
>
> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
>
> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> Cc: <[email protected]> # v5.4
> Signed-off-by: Arnd Bergmann <[email protected]>
Assuming you are going to apply directly to ARM-SoC,
Acked-by: Sekhar Nori <[email protected]>
Thanks,
Sekhar
> ---
> arch/arm/mach-davinci/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-davinci/Kconfig b/arch/arm/mach-davinci/Kconfig
> index dd427bd2768c..02b180ad7245 100644
> --- a/arch/arm/mach-davinci/Kconfig
> +++ b/arch/arm/mach-davinci/Kconfig
> @@ -9,6 +9,7 @@ menuconfig ARCH_DAVINCI
> select PM_GENERIC_DOMAINS if PM
> select PM_GENERIC_DOMAINS_OF if PM && OF
> select REGMAP_MMIO
> + select RESET_CONTROLLER
> select HAVE_IDE
> select PINCTRL_SINGLE
>
> --
> 2.20.0
>
Hi Arnd,
On 11/12/19 3:42 PM, Sekhar Nori wrote:
> Hi Arnd,
>
> On 11/12/19 1:21 AM, Arnd Bergmann wrote:
>> Selecting RESET_CONTROLLER is actually required, otherwise we
>> can get a link failure in the clock driver:
>>
>> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
>> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
>> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
>> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
>>
>> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
>> Cc: <[email protected]> # v5.4
>> Signed-off-by: Arnd Bergmann <[email protected]>
>
> Assuming you are going to apply directly to ARM-SoC,
>
> Acked-by: Sekhar Nori <[email protected]>
This is not yet in Linus's master. Let me know if I should collect it
and send a pull request.
Thanks,
Sekhar
On Mon, Jan 13, 2020 at 05:32:54PM +0530, Sekhar Nori wrote:
> Hi Arnd,
>
> On 11/12/19 3:42 PM, Sekhar Nori wrote:
> > Hi Arnd,
> >
> > On 11/12/19 1:21 AM, Arnd Bergmann wrote:
> >> Selecting RESET_CONTROLLER is actually required, otherwise we
> >> can get a link failure in the clock driver:
> >>
> >> drivers/clk/davinci/psc.o: In function `__davinci_psc_register_clocks':
> >> psc.c:(.text+0x9a0): undefined reference to `devm_reset_controller_register'
> >> drivers/clk/davinci/psc-da850.o: In function `da850_psc0_init':
> >> psc-da850.c:(.text+0x24): undefined reference to `reset_controller_add_lookup'
> >>
> >> Fixes: f962396ce292 ("ARM: davinci: support multiplatform build for ARM v5")
> >> Cc: <[email protected]> # v5.4
> >> Signed-off-by: Arnd Bergmann <[email protected]>
> >
> > Assuming you are going to apply directly to ARM-SoC,
> >
> > Acked-by: Sekhar Nori <[email protected]>
>
> This is not yet in Linus's master. Let me know if I should collect it
> and send a pull request.
It's sitting in our fixes branch and should show up in mainline in not too
long.
-Olof