2017-12-25 05:36:06

by Sumit Pundir

Subject: [PATCH] Staging: vt6656: Fix unnecessary parantheses

This patch fixes a few coding style issues as noted by checkpatch.pl
related to unnecessary parantheses.

This patch fixes the following checkpatch.pl warnings:

WARNING: Unnecessary parentheses around 'priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1'
WARNING: Unnecessary parentheses around 'priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4'

Signed-off-by: Sumit Pundir <[email protected]>
---
drivers/staging/vt6656/main_usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 1b51b83..c15ae72 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -266,8 +266,8 @@ static int vnt_init_registers(struct vnt_private *priv)

/* load vt3266 calibration parameters in EEPROM */
if (priv->rf_type == RF_VT3226D0) {
- if ((priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1) &&
- (priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4)) {
+ if (priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1 &&
+ priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4) {
calib_tx_iq = priv->eeprom[EEP_OFS_CALIB_TX_IQ];
calib_tx_dc = priv->eeprom[EEP_OFS_CALIB_TX_DC];
calib_rx_iq = priv->eeprom[EEP_OFS_CALIB_RX_IQ];
--
2.7.4

2018-01-08 15:45:25

by Greg Kroah-Hartman

Subject: Re: [PATCH] Staging: vt6656: Fix unnecessary parantheses

On Mon, Dec 25, 2017 at 11:05:34AM +0530, Sumit Pundir wrote:
> This patch fixes a few coding style issues as noted by checkpatch.pl
> related to unnecessary parantheses.
>
> This patch fixes the following checkpatch.pl warnings:
>
> WARNING: Unnecessary parentheses around 'priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1'
> WARNING: Unnecessary parentheses around 'priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4'
>
> Signed-off-by: Sumit Pundir <[email protected]>
> ---
> drivers/staging/vt6656/main_usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
> index 1b51b83..c15ae72 100644
> --- a/drivers/staging/vt6656/main_usb.c
> +++ b/drivers/staging/vt6656/main_usb.c
> @@ -266,8 +266,8 @@ static int vnt_init_registers(struct vnt_private *priv)
>
> /* load vt3266 calibration parameters in EEPROM */
> if (priv->rf_type == RF_VT3226D0) {
> - if ((priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1) &&
> - (priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4)) {
> + if (priv->eeprom[EEP_OFS_MAJOR_VER] == 0x1 &&
> + priv->eeprom[EEP_OFS_MINOR_VER] >= 0x4) {

No, now you have to guess if && or == or >= comes first :(