2018-01-03 09:38:48

by Sumit Pundir

Subject: [PATCH] Staging: greybus: audio_codec.h: Change uint32_t to u32

This patch fixes the following checkpatch.pl issues:

CHECK: Prefer kernel type 'u32' over 'uint32_t'
+ uint32_t format, rate;

CHECK: Prefer kernel type 'u32' over 'uint32_t'
+ uint32_t *rate, u8 *channels,

CHECK: Prefer kernel type 'u32' over 'uint32_t'
+ uint32_t rate, u8 channels,

Signed-off-by: Sumit Pundir <[email protected]>
---
drivers/staging/greybus/audio_codec.h | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
index 161b37c..fd7b893 100644
--- a/drivers/staging/greybus/audio_codec.h
+++ b/drivers/staging/greybus/audio_codec.h
@@ -53,7 +53,7 @@ enum gbaudio_codec_state {
struct gbaudio_stream_params {
int state;
u8 sig_bits, channels;
- uint32_t format, rate;
+ u32 format, rate;
};

struct gbaudio_codec_dai {
@@ -183,12 +183,12 @@ extern int gb_audio_gb_enable_widget(struct gb_connection *connection,
extern int gb_audio_gb_disable_widget(struct gb_connection *connection,
u8 widget_id);
extern int gb_audio_gb_get_pcm(struct gb_connection *connection,
- u16 data_cport, uint32_t *format,
- uint32_t *rate, u8 *channels,
+ u16 data_cport, u32 *format,
+ u32 *rate, u8 *channels,
u8 *sig_bits);
extern int gb_audio_gb_set_pcm(struct gb_connection *connection,
- u16 data_cport, uint32_t format,
- uint32_t rate, u8 channels,
+ u16 data_cport, u32 format,
+ u32 rate, u8 channels,
u8 sig_bits);
extern int gb_audio_gb_set_tx_data_size(struct gb_connection *connection,
u16 data_cport, u16 size);
--
2.7.4

2018-01-03 10:12:33

by Johan Hovold

Subject: Re: [PATCH] Staging: greybus: audio_codec.h: Change uint32_t to u32

On Wed, Jan 03, 2018 at 03:07:33PM +0530, Sumit Pundir wrote:
> This patch fixes the following checkpatch.pl issues:
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t format, rate;
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t *rate, u8 *channels,
>
> CHECK: Prefer kernel type 'u32' over 'uint32_t'
> + uint32_t rate, u8 channels,
>
> Signed-off-by: Sumit Pundir <[email protected]>
> ---
> drivers/staging/greybus/audio_codec.h | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)

Please fold this in with the changes to audio_codec.c and submit a
single patch for it all.

Thanks,
Johan