2018-01-05 10:32:25

by Sumit Pundir

Subject: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

This patch fixes the following checkpatch.pl issue at multiple lines:

WARNING: Prefer 'unsigned int' to bare use of 'unsigned'

Signed-off-by: Sumit Pundir <[email protected]>
---
drivers/staging/irda/drivers/act200l-sir.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/irda/drivers/act200l-sir.c b/drivers/staging/irda/drivers/act200l-sir.c
index e891751..62a02e5 100644
--- a/drivers/staging/irda/drivers/act200l-sir.c
+++ b/drivers/staging/irda/drivers/act200l-sir.c
@@ -29,7 +29,7 @@
static int act200l_reset(struct sir_dev *dev);
static int act200l_open(struct sir_dev *dev);
static int act200l_close(struct sir_dev *dev);
-static int act200l_change_speed(struct sir_dev *dev, unsigned speed);
+static int act200l_change_speed(struct sir_dev *dev, unsigned int speed);

/* Regsiter 0: Control register #1 */
#define ACT200L_REG0 0x00
@@ -134,7 +134,7 @@ static int act200l_close(struct sir_dev *dev)
* Set the speed for the ACTiSYS ACT-IR200L type dongle.
*
*/
-static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
+static int act200l_change_speed(struct sir_dev *dev, unsigned int speed)
{
u8 control[3];
int ret = 0;
@@ -191,8 +191,8 @@ static int act200l_change_speed(struct sir_dev *dev, unsigned speed)

static int act200l_reset(struct sir_dev *dev)
{
- unsigned state = dev->fsm.substate;
- unsigned delay = 0;
+ unsigned int state = dev->fsm.substate;
+ unsigned int delay = 0;
static const u8 control[9] = {
ACT200L_REG15,
ACT200L_REG13 | ACT200L_SHDW,
--
2.7.4

2018-01-05 10:44:09

by Shyam Saini

Subject: Re: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

Hi,

Did you read this?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO


Thanks,
Shyam


> This patch fixes the following checkpatch.pl issue at multiple lines:
>
> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>
> Signed-off-by: Sumit Pundir <[email protected]>
> ---
> drivers/staging/irda/drivers/act200l-sir.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/irda/drivers/act200l-sir.c b/drivers/staging/irda/drivers/act200l-sir.c
> index e891751..62a02e5 100644
> --- a/drivers/staging/irda/drivers/act200l-sir.c
> +++ b/drivers/staging/irda/drivers/act200l-sir.c
> @@ -29,7 +29,7 @@
> static int act200l_reset(struct sir_dev *dev);
> static int act200l_open(struct sir_dev *dev);
> static int act200l_close(struct sir_dev *dev);
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed);
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed);
>
> /* Regsiter 0: Control register #1 */
> #define ACT200L_REG0 0x00
> @@ -134,7 +134,7 @@ static int act200l_close(struct sir_dev *dev)
> * Set the speed for the ACTiSYS ACT-IR200L type dongle.
> *
> */
> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed)
> {
> u8 control[3];
> int ret = 0;
> @@ -191,8 +191,8 @@ static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
>
> static int act200l_reset(struct sir_dev *dev)
> {
> - unsigned state = dev->fsm.substate;
> - unsigned delay = 0;
> + unsigned int state = dev->fsm.substate;
> + unsigned int delay = 0;
> static const u8 control[9] = {
> ACT200L_REG15,
> ACT200L_REG13 | ACT200L_SHDW,
> --
> 2.7.4
>

2018-01-05 11:10:26

by Sumit Pundir

Subject: Re: [PATCH] Staging: irda: Prefer 'unsigned int' to bare use of 'unsigned'

On Fri, Jan 5, 2018 at 4:14 PM, Shyam Saini <[email protected]> wrote:
> Hi,
>
> Did you read this?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO
>
>
> Thanks,
> Shyam

Hi Shyam,

Thanks for the update. Totally forgot to read it.

Thanks,
Sumit

On Fri, Jan 5, 2018 at 4:14 PM, Shyam Saini <[email protected]> wrote:
> Hi,
>
> Did you read this?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/staging/irda/TODO
>
>
> Thanks,
> Shyam
>
>
>> This patch fixes the following checkpatch.pl issue at multiple lines:
>>
>> WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
>>
>> Signed-off-by: Sumit Pundir <[email protected]>
>> ---
>> drivers/staging/irda/drivers/act200l-sir.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/staging/irda/drivers/act200l-sir.c b/drivers/staging/irda/drivers/act200l-sir.c
>> index e891751..62a02e5 100644
>> --- a/drivers/staging/irda/drivers/act200l-sir.c
>> +++ b/drivers/staging/irda/drivers/act200l-sir.c
>> @@ -29,7 +29,7 @@
>> static int act200l_reset(struct sir_dev *dev);
>> static int act200l_open(struct sir_dev *dev);
>> static int act200l_close(struct sir_dev *dev);
>> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed);
>> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed);
>>
>> /* Regsiter 0: Control register #1 */
>> #define ACT200L_REG0 0x00
>> @@ -134,7 +134,7 @@ static int act200l_close(struct sir_dev *dev)
>> * Set the speed for the ACTiSYS ACT-IR200L type dongle.
>> *
>> */
>> -static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
>> +static int act200l_change_speed(struct sir_dev *dev, unsigned int speed)
>> {
>> u8 control[3];
>> int ret = 0;
>> @@ -191,8 +191,8 @@ static int act200l_change_speed(struct sir_dev *dev, unsigned speed)
>>
>> static int act200l_reset(struct sir_dev *dev)
>> {
>> - unsigned state = dev->fsm.substate;
>> - unsigned delay = 0;
>> + unsigned int state = dev->fsm.substate;
>> + unsigned int delay = 0;
>> static const u8 control[9] = {
>> ACT200L_REG15,
>> ACT200L_REG13 | ACT200L_SHDW,
>> --
>> 2.7.4
>>