2018-01-09 04:41:47

by Vinod Koul

[permalink] [raw]
Subject: [PATCH] soundwire: Fix incorrect return value check

From: Shreyas NC <[email protected]>

pm_runtime_get_sync will return negative values for error
and 0 or 1 for success. Update the error check accordingly.

Signed-off-by: Shreyas NC <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Fixes: 9d715fa005eb: ("soundwire: Add IO transfer")
Signed-off-by: Vinod Koul <[email protected]>
---
drivers/soundwire/bus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soundwire/bus.c b/drivers/soundwire/bus.c
index 03313590b661..5d7226c251e6 100644
--- a/drivers/soundwire/bus.c
+++ b/drivers/soundwire/bus.c
@@ -305,7 +305,7 @@ int sdw_nread(struct sdw_slave *slave, u32 addr, size_t count, u8 *val)
return ret;

ret = pm_runtime_get_sync(slave->bus->dev);
- if (!ret)
+ if (ret < 0)
return ret;

ret = sdw_transfer(slave->bus, &msg);
@@ -333,7 +333,7 @@ int sdw_nwrite(struct sdw_slave *slave, u32 addr, size_t count, u8 *val)
return ret;

ret = pm_runtime_get_sync(slave->bus->dev);
- if (!ret)
+ if (ret < 0)
return ret;

ret = sdw_transfer(slave->bus, &msg);
--
2.7.4