2018-01-19 19:20:38

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH] c6x: fix platforms/plldata.c get_coreid build error

From: Randy Dunlap <[email protected]>

Fix build error reported by the 0day bot by including the header
file for that macro.

Fixes this build error: (should fix; not tested)
arch/c6x/platforms/plldata.c: In function 'c6472_setup_clocks':
arch/c6x/platforms/plldata.c:279:33: error: implicit declaration of function 'get_coreid'; did you mean 'get_order'? [-Werror=implicit-function-declaration]
c6x_core_clk.parent = &sysclks[get_coreid() + 1];

Reported-by: Fengguang Wu <[email protected]>
Cc: Mark Salter <[email protected]>
Cc: Aurelien Jacquiot <[email protected]>
Cc: [email protected]
Cc: Ingo Molnar <[email protected]>

Signed-off-by: Randy Dunlap <[email protected]>
---
arch/c6x/platforms/plldata.c | 1 +
1 file changed, 1 insertion(+)

--- lnx-415-rc8.orig/arch/c6x/platforms/plldata.c
+++ lnx-415-rc8/arch/c6x/platforms/plldata.c
@@ -19,6 +19,7 @@

#include <asm/clock.h>
#include <asm/setup.h>
+#include <asm/special_insns.h>
#include <asm/irq.h>

/*



2018-01-23 23:15:59

by Mark Salter

[permalink] [raw]
Subject: Re: [PATCH] c6x: fix platforms/plldata.c get_coreid build error

On Fri, 2018-01-19 at 11:19 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix build error reported by the 0day bot by including the header
> file for that macro.

Thanks. I pulled this into the c6x tree.

>
> Fixes this build error: (should fix; not tested)
> arch/c6x/platforms/plldata.c: In function 'c6472_setup_clocks':
> arch/c6x/platforms/plldata.c:279:33: error: implicit declaration of function 'get_coreid'; did you mean 'get_order'? [-Werror=implicit-function-declaration]
> c6x_core_clk.parent = &sysclks[get_coreid() + 1];
>
> Reported-by: Fengguang Wu <[email protected]>
> Cc: Mark Salter <[email protected]>
> Cc: Aurelien Jacquiot <[email protected]>
> Cc: [email protected]
> Cc: Ingo Molnar <[email protected]>
>
> Signed-off-by: Randy Dunlap <[email protected]>
> ---
> arch/c6x/platforms/plldata.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- lnx-415-rc8.orig/arch/c6x/platforms/plldata.c
> +++ lnx-415-rc8/arch/c6x/platforms/plldata.c
> @@ -19,6 +19,7 @@
>
> #include <asm/clock.h>
> #include <asm/setup.h>
> +#include <asm/special_insns.h>
> #include <asm/irq.h>
>
> /*
>