2018-01-24 04:23:39

by Asutosh Das (asd)

Subject: [PATCH 1/1] scsi: ufs: Enable quirk to ignore sending WRITE_SAME command

From: Sujit Reddy Thumma <[email protected]>

WRITE_SAME command is not supported by UFS. Enable a quirk for
the upper level drivers to not send WRITE SAME command.

Signed-off-by: Sujit Reddy Thumma <[email protected]>
Signed-off-by: Subhash Jadavani <[email protected]>
Signed-off-by: Asutosh Das <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 8af2af3..5a8dc3b 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -4356,6 +4356,9 @@ static int ufshcd_slave_alloc(struct scsi_device *sdev)
/* WRITE_SAME command is not supported*/
sdev->no_write_same = 1;

+ /* WRITE_SAME command is not supported*/
+ sdev->no_write_same = 1;
+
ufshcd_set_queue_depth(sdev);

ufshcd_get_lu_power_on_wp_status(hba, sdev);
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.

2018-01-31 03:39:38

by Martin K. Petersen

Subject: Re: [PATCH 1/1] scsi: ufs: Enable quirk to ignore sending WRITE_SAME command

Asutosh,

> /* WRITE_SAME command is not supported*/
> sdev->no_write_same = 1;
>
> + /* WRITE_SAME command is not supported*/
> + sdev->no_write_same = 1;
> +

Uhm...

I applied this change to 4.16/scsi-fixes by hand.

--
Martin K. Petersen Oracle Linux Engineering