2018-01-31 06:52:40

by Rajneesh Bhardwaj

[permalink] [raw]
Subject: [PATCH] platform/x86: intel_pmc_core: Remove unused header file

Recently sent patch 'platform/x86: intel_pmc_core: Remove unused EXPORTED
API' missed to remove the header file 'arch/x86/include/asm/pmc_core.h'
which was solely used to declare the EXPORTED API
'intel_pmc_slp_s0_counter_read'. This patch provides the errata fix for the
same.

Signed-off-by: Rajneesh Bhardwaj <[email protected]>
---
arch/x86/include/asm/pmc_core.h | 27 ---------------------------
drivers/platform/x86/intel_pmc_core.c | 1 -
2 files changed, 28 deletions(-)
delete mode 100644 arch/x86/include/asm/pmc_core.h

diff --git a/arch/x86/include/asm/pmc_core.h b/arch/x86/include/asm/pmc_core.h
deleted file mode 100644
index d4855f11136d..000000000000
--- a/arch/x86/include/asm/pmc_core.h
+++ /dev/null
@@ -1,27 +0,0 @@
-/*
- * Intel Core SoC Power Management Controller Header File
- *
- * Copyright (c) 2016, Intel Corporation.
- * All Rights Reserved.
- *
- * Authors: Rajneesh Bhardwaj <[email protected]>
- * Vishwanath Somayaji <[email protected]>
- *
- * This program is free software; you can redistribute it and/or modify it
- * under the terms and conditions of the GNU General Public License,
- * version 2, as published by the Free Software Foundation.
- *
- * This program is distributed in the hope it will be useful, but WITHOUT
- * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
- * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
- * more details.
- *
- */
-
-#ifndef _ASM_PMC_CORE_H
-#define _ASM_PMC_CORE_H
-
-/* API to read SLP_S0_RESIDENCY counter */
-int intel_pmc_slp_s0_counter_read(u32 *data);
-
-#endif /* _ASM_PMC_CORE_H */
diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index 67e85ee4ab32..180c65fed55a 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -30,7 +30,6 @@

#include <asm/cpu_device_id.h>
#include <asm/intel-family.h>
-#include <asm/pmc_core.h>

#include "intel_pmc_core.h"

--
2.7.4



2018-01-31 16:55:06

by Andy Shevchenko

[permalink] [raw]
Subject: Re: [PATCH] platform/x86: intel_pmc_core: Remove unused header file

On Wed, Jan 31, 2018 at 8:20 AM, Rajneesh Bhardwaj
<[email protected]> wrote:
> Recently sent patch 'platform/x86: intel_pmc_core: Remove unused EXPORTED
> API' missed to remove the header file 'arch/x86/include/asm/pmc_core.h'
> which was solely used to declare the EXPORTED API
> 'intel_pmc_slp_s0_counter_read'. This patch provides the errata fix for the
> same.

Pushed to my review and testing queue, thanks!

>
> Signed-off-by: Rajneesh Bhardwaj <[email protected]>
> ---
> arch/x86/include/asm/pmc_core.h | 27 ---------------------------
> drivers/platform/x86/intel_pmc_core.c | 1 -
> 2 files changed, 28 deletions(-)
> delete mode 100644 arch/x86/include/asm/pmc_core.h
>
> diff --git a/arch/x86/include/asm/pmc_core.h b/arch/x86/include/asm/pmc_core.h
> deleted file mode 100644
> index d4855f11136d..000000000000
> --- a/arch/x86/include/asm/pmc_core.h
> +++ /dev/null
> @@ -1,27 +0,0 @@
> -/*
> - * Intel Core SoC Power Management Controller Header File
> - *
> - * Copyright (c) 2016, Intel Corporation.
> - * All Rights Reserved.
> - *
> - * Authors: Rajneesh Bhardwaj <[email protected]>
> - * Vishwanath Somayaji <[email protected]>
> - *
> - * This program is free software; you can redistribute it and/or modify it
> - * under the terms and conditions of the GNU General Public License,
> - * version 2, as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope it will be useful, but WITHOUT
> - * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
> - * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
> - * more details.
> - *
> - */
> -
> -#ifndef _ASM_PMC_CORE_H
> -#define _ASM_PMC_CORE_H
> -
> -/* API to read SLP_S0_RESIDENCY counter */
> -int intel_pmc_slp_s0_counter_read(u32 *data);
> -
> -#endif /* _ASM_PMC_CORE_H */
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index 67e85ee4ab32..180c65fed55a 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -30,7 +30,6 @@
>
> #include <asm/cpu_device_id.h>
> #include <asm/intel-family.h>
> -#include <asm/pmc_core.h>
>
> #include "intel_pmc_core.h"
>
> --
> 2.7.4
>



--
With Best Regards,
Andy Shevchenko