2018-02-01 02:04:39

by Yisheng Xie

Subject: [PATCH resend 1/3] staging: android: ion: Remove unused declaration ion_buffer_fault_user_mappings

ion_buffer_fault_user_mappings's definition has been removed and not be
used anymore, just remove its useless declaration.

Signed-off-by: Yisheng Xie <[email protected]>
---
drivers/staging/android/ion/ion.h | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
index f5f9cd6..2160c35 100644
--- a/drivers/staging/android/ion/ion.h
+++ b/drivers/staging/android/ion/ion.h
@@ -201,15 +201,6 @@ struct ion_heap {
bool ion_buffer_cached(struct ion_buffer *buffer);

/**
- * ion_buffer_fault_user_mappings - fault in user mappings of this buffer
- * @buffer: buffer
- *
- * indicates whether userspace mappings of this buffer will be faulted
- * in, this can affect how buffers are allocated from the heap.
- */
-bool ion_buffer_fault_user_mappings(struct ion_buffer *buffer);
-
-/**
* ion_device_add_heap - adds a heap to the ion device
* @heap: the heap to add
*/
--
1.7.12.4

2018-02-01 02:04:55

by Yisheng Xie

Subject: [PATCH resend 2/3] staging: android: ion: Remove unused include files for ion_page_pool.c

After rewrite of ion_page_pool, some of its include file is no need
anymore, just remove it.

Signed-off-by: Yisheng Xie <[email protected]>
---
drivers/staging/android/ion/ion_page_pool.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
index 817849d..f2318c9 100644
--- a/drivers/staging/android/ion/ion_page_pool.c
+++ b/drivers/staging/android/ion/ion_page_pool.c
@@ -14,10 +14,6 @@
*
*/

-#include <linux/debugfs.h>
-#include <linux/dma-mapping.h>
-#include <linux/err.h>
-#include <linux/fs.h>
#include <linux/list.h>
#include <linux/init.h>
#include <linux/slab.h>
--
1.7.12.4

2018-02-01 02:05:56

by Yisheng Xie

Subject: [PATCH resend 3/3] staging: android: ion: Nuke ion_page_pool_init

ion_page_pool.c now is used to apply pool APIs for system heap, which do
not need do any initial at device_initcall. Therefore ion_page_pool_init
can be nuked.

Signed-off-by: Yisheng Xie <[email protected]>
---
drivers/staging/android/ion/ion_page_pool.c | 7 -------
1 file changed, 7 deletions(-)

diff --git a/drivers/staging/android/ion/ion_page_pool.c b/drivers/staging/android/ion/ion_page_pool.c
index f2318c9..3c1eba5 100644
--- a/drivers/staging/android/ion/ion_page_pool.c
+++ b/drivers/staging/android/ion/ion_page_pool.c
@@ -15,7 +15,6 @@
*/

#include <linux/list.h>
-#include <linux/init.h>
#include <linux/slab.h>
#include <linux/swap.h>

@@ -167,9 +166,3 @@ void ion_page_pool_destroy(struct ion_page_pool *pool)
{
kfree(pool);
}
-
-static int __init ion_page_pool_init(void)
-{
- return 0;
-}
-device_initcall(ion_page_pool_init);
--
1.7.12.4

2018-02-12 11:41:37

by Yisheng Xie

Subject: Re: [PATCH resend 1/3] staging: android: ion: Remove unused declaration ion_buffer_fault_user_mappings

Hi Greg,

JFYI, I have rebase this patchset to v4.15-rc1.[1]

[1] https://lkml.org/lkml/2018/2/12/204

Thanks
Yisheng

On 2018/2/1 9:54, Yisheng Xie wrote:
> ion_buffer_fault_user_mappings's definition has been removed and not be
> used anymore, just remove its useless declaration.
>
> Signed-off-by: Yisheng Xie <[email protected]>
> ---
> drivers/staging/android/ion/ion.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
> index f5f9cd6..2160c35 100644
> --- a/drivers/staging/android/ion/ion.h
> +++ b/drivers/staging/android/ion/ion.h
> @@ -201,15 +201,6 @@ struct ion_heap {
> bool ion_buffer_cached(struct ion_buffer *buffer);
>
> /**
> - * ion_buffer_fault_user_mappings - fault in user mappings of this buffer
> - * @buffer: buffer
> - *
> - * indicates whether userspace mappings of this buffer will be faulted
> - * in, this can affect how buffers are allocated from the heap.
> - */
> -bool ion_buffer_fault_user_mappings(struct ion_buffer *buffer);
> -
> -/**
> * ion_device_add_heap - adds a heap to the ion device
> * @heap: the heap to add
> */
>

2018-02-14 02:56:27

by Yisheng Xie

Subject: Re: [PATCH resend 1/3] staging: android: ion: Remove unused declaration ion_buffer_fault_user_mappings

Hi Greg

On 2018/2/12 19:40, Yisheng Xie wrote:
> Hi Greg,
>
> JFYI, I have rebase this patchset to v4.15-rc1.[1]

Ah, sorry , I mean v4.16-rc1, and the same to other threads.

Thanks
Yisheng

>
> [1] https://lkml.org/lkml/2018/2/12/204
>
> Thanks
> Yisheng
>
> On 2018/2/1 9:54, Yisheng Xie wrote:
>> ion_buffer_fault_user_mappings's definition has been removed and not be
>> used anymore, just remove its useless declaration.
>>
>> Signed-off-by: Yisheng Xie <[email protected]>
>> ---
>> drivers/staging/android/ion/ion.h | 9 ---------
>> 1 file changed, 9 deletions(-)
>>
>> diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
>> index f5f9cd6..2160c35 100644
>> --- a/drivers/staging/android/ion/ion.h
>> +++ b/drivers/staging/android/ion/ion.h
>> @@ -201,15 +201,6 @@ struct ion_heap {
>> bool ion_buffer_cached(struct ion_buffer *buffer);
>>
>> /**
>> - * ion_buffer_fault_user_mappings - fault in user mappings of this buffer
>> - * @buffer: buffer
>> - *
>> - * indicates whether userspace mappings of this buffer will be faulted
>> - * in, this can affect how buffers are allocated from the heap.
>> - */
>> -bool ion_buffer_fault_user_mappings(struct ion_buffer *buffer);
>> -
>> -/**
>> * ion_device_add_heap - adds a heap to the ion device
>> * @heap: the heap to add
>> */
>>
>
>
> .
>