2018-02-08 19:12:54

by Mike Rapoport

[permalink] [raw]
Subject: [PATCH] mm/zpool: zpool_evictable: fix mismatch in parameter name and kernel-doc

Signed-off-by: Mike Rapoport <[email protected]>
---
mm/zpool.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/zpool.c b/mm/zpool.c
index f8cb83e7699b..9d53a1ef8f1e 100644
--- a/mm/zpool.c
+++ b/mm/zpool.c
@@ -360,7 +360,7 @@ u64 zpool_get_total_size(struct zpool *zpool)

/**
* zpool_evictable() - Test if zpool is potentially evictable
- * @pool The zpool to test
+ * @zpool The zpool to test
*
* Zpool is only potentially evictable when it's created with struct
* zpool_ops.evict and its driver implements struct zpool_driver.shrink.
--
2.7.4



2018-02-08 19:18:36

by Randy Dunlap

[permalink] [raw]
Subject: Re: [PATCH] mm/zpool: zpool_evictable: fix mismatch in parameter name and kernel-doc

On 02/08/2018 11:09 AM, Mike Rapoport wrote:
> Signed-off-by: Mike Rapoport <[email protected]>
> ---
> mm/zpool.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/zpool.c b/mm/zpool.c
> index f8cb83e7699b..9d53a1ef8f1e 100644
> --- a/mm/zpool.c
> +++ b/mm/zpool.c
> @@ -360,7 +360,7 @@ u64 zpool_get_total_size(struct zpool *zpool)
>
> /**
> * zpool_evictable() - Test if zpool is potentially evictable
> - * @pool The zpool to test
> + * @zpool The zpool to test

+ * @zpool: The zpool to test

> *
> * Zpool is only potentially evictable when it's created with struct
> * zpool_ops.evict and its driver implements struct zpool_driver.shrink.
>


--
~Randy

2018-02-09 10:59:00

by Mike Rapoport

[permalink] [raw]
Subject: Re: [PATCH] mm/zpool: zpool_evictable: fix mismatch in parameter name and kernel-doc

On Thu, Feb 08, 2018 at 11:17:33AM -0800, Randy Dunlap wrote:
> On 02/08/2018 11:09 AM, Mike Rapoport wrote:
> > Signed-off-by: Mike Rapoport <[email protected]>
> > ---
> > mm/zpool.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/zpool.c b/mm/zpool.c
> > index f8cb83e7699b..9d53a1ef8f1e 100644
> > --- a/mm/zpool.c
> > +++ b/mm/zpool.c
> > @@ -360,7 +360,7 @@ u64 zpool_get_total_size(struct zpool *zpool)
> >
> > /**
> > * zpool_evictable() - Test if zpool is potentially evictable
> > - * @pool The zpool to test
> > + * @zpool The zpool to test
>
> + * @zpool: The zpool to test

Thanks!

> > *
> > * Zpool is only potentially evictable when it's created with struct
> > * zpool_ops.evict and its driver implements struct zpool_driver.shrink.
> >
>
>
> --
> ~Randy
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to [email protected]. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
>

--
Sincerely yours,
Mike.