2018-02-14 12:20:33

by Corentin LABBE

Subject: [PATCH] powerpc: add empty update_numa_cpu_lookup_table for !CONFIG_NUMA

When CONFIG_NUMA is not set, build fail with:
arch/powerpc/platforms/pseries/hotplug-cpu.c:335:4: error: déclaration implicite de la fonction « update_numa_cpu_lookup_table » [-Werror=implicit-function-declaration]

So we have to add update_numa_cpu_lookup_table as an empty function when CONFIG_NUMA is not set.

Fixes: 1d9a090783be ("powerpc/numa: Invalidate numa_cpu_lookup_table on cpu remove")
Signed-off-by: Corentin Labbe <[email protected]>
---
arch/powerpc/include/asm/topology.h | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/include/asm/topology.h b/arch/powerpc/include/asm/topology.h
index 593248110902..9f421641a35c 100644
--- a/arch/powerpc/include/asm/topology.h
+++ b/arch/powerpc/include/asm/topology.h
@@ -81,6 +81,9 @@ static inline int numa_update_cpu_topology(bool cpus_locked)
{
return 0;
}
+
+static inline void update_numa_cpu_lookup_table(unsigned int cpu, int node) {}
+
#endif /* CONFIG_NUMA */

#if defined(CONFIG_NUMA) && defined(CONFIG_PPC_SPLPAR)
--
2.13.6

2018-02-18 08:59:04

by Michael Ellerman

Subject: Re: powerpc: add empty update_numa_cpu_lookup_table for !CONFIG_NUMA

On Wed, 2018-02-14 at 12:17:47 UTC, Corentin Labbe wrote:
> When CONFIG_NUMA is not set, build fail with:
> arch/powerpc/platforms/pseries/hotplug-cpu.c:335:4: error: déclaration implicite de la fonction « update_numa_cpu_lookup_table » [-Werror=implicit-function-declaration]
>
> So we have to add update_numa_cpu_lookup_table as an empty function when CONFIG_NUMA is not set.
>
> Fixes: 1d9a090783be ("powerpc/numa: Invalidate numa_cpu_lookup_table on cpu remove")
> Signed-off-by: Corentin Labbe <[email protected]>

Applied to powerpc fixes, thanks.

https://git.kernel.org/powerpc/c/c1e150ceb61e4a585bad156da15c33

cheers