2018-02-26 02:46:41

by Yong

Subject: [PATCH] ASoC: sun4i-i2s: Fix RX slot number of SUN8I

I2S's RX slot number of SUN8I should be shifted 4 bit to left.

Fixes: 7d2993811a1e ("ASoC: sun4i-i2s: Add support for H3")

Signed-off-by: Yong Deng <[email protected]>
---
sound/soc/sunxi/sun4i-i2s.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c
index dca1143c1150..a4aa931ebfae 100644
--- a/sound/soc/sunxi/sun4i-i2s.c
+++ b/sound/soc/sunxi/sun4i-i2s.c
@@ -104,7 +104,7 @@

#define SUN8I_I2S_CHAN_CFG_REG 0x30
#define SUN8I_I2S_CHAN_CFG_RX_SLOT_NUM_MASK GENMASK(6, 4)
-#define SUN8I_I2S_CHAN_CFG_RX_SLOT_NUM(chan) (chan - 1)
+#define SUN8I_I2S_CHAN_CFG_RX_SLOT_NUM(chan) ((chan - 1) << 4)
#define SUN8I_I2S_CHAN_CFG_TX_SLOT_NUM_MASK GENMASK(2, 0)
#define SUN8I_I2S_CHAN_CFG_TX_SLOT_NUM(chan) (chan - 1)

--
1.8.3.1

2018-02-26 02:56:53

by Chen-Yu Tsai

Subject: Re: [PATCH] ASoC: sun4i-i2s: Fix RX slot number of SUN8I

On Mon, Feb 26, 2018 at 10:43 AM, Yong Deng <[email protected]> wrote:
> I2S's RX slot number of SUN8I should be shifted 4 bit to left.
>
> Fixes: 7d2993811a1e ("ASoC: sun4i-i2s: Add support for H3")
>
> Signed-off-by: Yong Deng <[email protected]>

Reviewed-by: Chen-Yu Tsai <[email protected]>