2018-02-27 22:33:42

by Hernán Gonzalez

Subject: [PATCH] qlogic/qed: Constify *pkt_type_str[]

Note: This is compile only tested as I have no access to the hw.
Constifying and declaring as static saves 24 bytes.

add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-24 (-24)
Function old new delta
pkt_type_str 24 - -24
Total: Before=3599256, After=3599232, chg -0.00%

Signed-off-by: Hernán Gonzalez <[email protected]>
---
drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
index ca4a81d..03ad4ee 100644
--- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
+++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
@@ -1784,7 +1784,7 @@ enum qed_iwarp_mpa_pkt_type {
/* fpdu can be fragmented over maximum 3 bds: header, partial mpa, unaligned */
#define QED_IWARP_MAX_BDS_PER_FPDU 3

-char *pkt_type_str[] = {
+static const char * const pkt_type_str[] = {
"QED_IWARP_MPA_PKT_PACKED",
"QED_IWARP_MPA_PKT_PARTIAL",
"QED_IWARP_MPA_PKT_UNALIGNED"
--
2.7.4

2018-02-28 08:24:42

by Kalderon, Michal

Subject: RE: [PATCH] qlogic/qed: Constify *pkt_type_str[]

> From: Hernán Gonzalez [mailto:[email protected]]
> Sent: Wednesday, February 28, 2018 12:32 AM
>
> Note: This is compile only tested as I have no access to the hw.
> Constifying and declaring as static saves 24 bytes.
>
> add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-24 (-24)
> Function old new delta
> pkt_type_str 24 - -24
> Total: Before=3599256, After=3599232, chg -0.00%
>
> Signed-off-by: Hernán Gonzalez <[email protected]>
> ---
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> index ca4a81d..03ad4ee 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_iwarp.c
> @@ -1784,7 +1784,7 @@ enum qed_iwarp_mpa_pkt_type {
> /* fpdu can be fragmented over maximum 3 bds: header, partial mpa,
> unaligned */ #define QED_IWARP_MAX_BDS_PER_FPDU 3
>
> -char *pkt_type_str[] = {
> +static const char * const pkt_type_str[] = {
> "QED_IWARP_MPA_PKT_PACKED",
> "QED_IWARP_MPA_PKT_PARTIAL",
> "QED_IWARP_MPA_PKT_UNALIGNED"
> --
> 2.7.4

Thanks

Acked-by: Michal Kalderon <[email protected]>

2018-02-28 16:40:54

by David Miller

Subject: Re: [PATCH] qlogic/qed: Constify *pkt_type_str[]

From: Hern?n Gonzalez <[email protected]>
Date: Tue, 27 Feb 2018 19:31:34 -0300

> Note: This is compile only tested as I have no access to the hw.
> Constifying and declaring as static saves 24 bytes.
>
> add/remove: 0/1 grow/shrink: 0/0 up/down: 0/-24 (-24)
> Function old new delta
> pkt_type_str 24 - -24
> Total: Before=3599256, After=3599232, chg -0.00%
>
> Signed-off-by: Hern?n Gonzalez <[email protected]>

Applied to net-next.