From: Bean Huo <[email protected]>
Changelog:
v6--v7:
1. Change wb_on sysfs documentation and add information that WriteBooster
is already enabled after power-on/reset(Incorporate Adrian Hunter's suggestion)
v5--v6:
1. Remove original patch 7/7:
"scsi: ufs: Keep device active mode only fWriteBoosterBufferFlushDuringHibernate == 1"
2. Rebased patch onto 5.12/scsi-staging
3. Add protection of PM ops and err_handler for the wb_on entry access
V4--V5:
1. Add patch "docs: ABI: Add wb_on documentation for UFS sysfs"
2. Unify WB related flags with wb_* prefix (Stanley Chu)
3. Delete d_ext_ufs_feature_sup (Stanley Chu)
4. Incorporate Stanley's suggestion to patch 6/7
5. Replace scnprintf() with sysfs_emit() in 1/7 (Greg KH)
v3--v4:
1. Rebase patch on 5.11/scsi-staging
2. Add WB cleanup patches 3/6, 4/6 adn 5/6
v2--v3:
1. Change multi-line comments style in patch 1/3 (Can Guo)
v1--v2:
1. Take is_hibern8_wb_flush checkup out from function
ufshcd_wb_need_flush() in patch 2/3
2. Add UFSHCD_CAP_CLK_SCALING checkup in patch 1/3. that means
only for the platform, which doesn't support UFSHCD_CAP_CLK_SCALING,
can control WB through "wb_on".
Bean Huo (6):
scsi: ufs: Add "wb_on" sysfs node to control WB on/off
docs: ABI: Add wb_on documentation for new entry wb_on
scsi: ufs: Changes comment in the function ufshcd_wb_probe()
scsi: ufs: Remove two WB related fields from struct ufs_dev_info
scsi: ufs: Group UFS WB related flags to struct ufs_dev_info
scsi: ufs: Cleanup WB buffer flush toggle implementation
Documentation/ABI/testing/sysfs-driver-ufs | 11 +++
drivers/scsi/ufs/ufs-sysfs.c | 46 +++++++++
drivers/scsi/ufs/ufs.h | 29 +++---
drivers/scsi/ufs/ufshcd.c | 103 ++++++++-------------
drivers/scsi/ufs/ufshcd.h | 6 +-
5 files changed, 113 insertions(+), 82 deletions(-)
--
2.17.1
Bean,
> Bean Huo (6):
> scsi: ufs: Add "wb_on" sysfs node to control WB on/off
> docs: ABI: Add wb_on documentation for new entry wb_on
> scsi: ufs: Changes comment in the function ufshcd_wb_probe()
> scsi: ufs: Remove two WB related fields from struct ufs_dev_info
> scsi: ufs: Group UFS WB related flags to struct ufs_dev_info
> scsi: ufs: Cleanup WB buffer flush toggle implementation
Applied patches 1-5 to 5.12/scsi-staging. Patch 6 didn't apply, please
resubmit.
Also, I had to fix up your sysfs ABI documentation indentation.
--
Martin K. Petersen Oracle Linux Engineering
On Wed, 2021-01-20 at 22:15 -0500, Martin K. Petersen wrote:
> Bean,
>
> > Bean Huo (6):
> > scsi: ufs: Add "wb_on" sysfs node to control WB on/off
> > docs: ABI: Add wb_on documentation for new entry wb_on
> > scsi: ufs: Changes comment in the function ufshcd_wb_probe()
> > scsi: ufs: Remove two WB related fields from struct ufs_dev_info
> > scsi: ufs: Group UFS WB related flags to struct ufs_dev_info
> > scsi: ufs: Cleanup WB buffer flush toggle implementation
>
> Applied patches 1-5 to 5.12/scsi-staging. Patch 6 didn't apply,
> please
> resubmit.
>
> Also, I had to fix up your sysfs ABI documentation indentation.
Martin,
thanks. I will update patch 6 later.
Thanks,
Bean
On Tue, 19 Jan 2021 17:38:41 +0100, Bean Huo wrote:
> Changelog:
>
> v6--v7:
> 1. Change wb_on sysfs documentation and add information that WriteBooster
> is already enabled after power-on/reset(Incorporate Adrian Hunter's suggestion)
>
> v5--v6:
> 1. Remove original patch 7/7:
> "scsi: ufs: Keep device active mode only fWriteBoosterBufferFlushDuringHibernate == 1"
> 2. Rebased patch onto 5.12/scsi-staging
> 3. Add protection of PM ops and err_handler for the wb_on entry access
>
> [...]
Applied to 5.12/scsi-queue, thanks!
[1/6] scsi: ufs: Add "wb_on" sysfs node to control WB on/off
https://git.kernel.org/mkp/scsi/c/8e834ca551ad
[2/6] docs: ABI: Add wb_on documentation for new entry wb_on
https://git.kernel.org/mkp/scsi/c/06aea26676a5
[3/6] scsi: ufs: Changes comment in the function ufshcd_wb_probe()
https://git.kernel.org/mkp/scsi/c/ae1ce1fc61d4
[4/6] scsi: ufs: Remove two WB related fields from struct ufs_dev_info
https://git.kernel.org/mkp/scsi/c/e8d038139420
[5/6] scsi: ufs: Group UFS WB related flags to struct ufs_dev_info
https://git.kernel.org/mkp/scsi/c/4cd48995645b
--
Martin K. Petersen Oracle Linux Engineering