2018-02-08 18:09:04

by Sean Wang

Subject: [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added

From: Sean Wang <[email protected]>

Fix the pointer to struct scp_subdomian not being moved forward
when each sub-domain is expected to be iteratively added through
pm_genpd_add_subdomain call.

Cc: [email protected]
Fixes: 53fddb1a66dd ("soc: mediatek: reduce code duplication of scpsys_probe across all SoCs")
Reported-by: Weiyi Lu <[email protected]>
Signed-off-by: Sean Wang <[email protected]>
---
drivers/soc/mediatek/mtk-scpsys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
index fc55faa..9de801e 100644
--- a/drivers/soc/mediatek/mtk-scpsys.c
+++ b/drivers/soc/mediatek/mtk-scpsys.c
@@ -1048,7 +1048,7 @@ static int scpsys_probe(struct platform_device *pdev)

pd_data = &scp->pd_data;

- for (i = 0, sd = soc->subdomains ; i < soc->num_subdomains ; i++) {
+ for (i = 0, sd = soc->subdomains; i < soc->num_subdomains; i++, sd++) {
ret = pm_genpd_add_subdomain(pd_data->domains[sd->origin],
pd_data->domains[sd->subdomain]);
if (ret && IS_ENABLED(CONFIG_PM))
--
2.7.4

2018-03-07 09:22:58

by Sean Wang

Subject: Re: [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added

Hi, Matthis

also a gentle ping for the patch

Sean

On Fri, 2018-02-09 at 02:07 +0800, [email protected] wrote:
> From: Sean Wang <[email protected]>
>
> Fix the pointer to struct scp_subdomian not being moved forward
> when each sub-domain is expected to be iteratively added through
> pm_genpd_add_subdomain call.
>
> Cc: [email protected]
> Fixes: 53fddb1a66dd ("soc: mediatek: reduce code duplication of scpsys_probe across all SoCs")
> Reported-by: Weiyi Lu <[email protected]>
> Signed-off-by: Sean Wang <[email protected]>
> ---
> drivers/soc/mediatek/mtk-scpsys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
> index fc55faa..9de801e 100644
> --- a/drivers/soc/mediatek/mtk-scpsys.c
> +++ b/drivers/soc/mediatek/mtk-scpsys.c
> @@ -1048,7 +1048,7 @@ static int scpsys_probe(struct platform_device *pdev)
>
> pd_data = &scp->pd_data;
>
> - for (i = 0, sd = soc->subdomains ; i < soc->num_subdomains ; i++) {
> + for (i = 0, sd = soc->subdomains; i < soc->num_subdomains; i++, sd++) {
> ret = pm_genpd_add_subdomain(pd_data->domains[sd->origin],
> pd_data->domains[sd->subdomain]);
> if (ret && IS_ENABLED(CONFIG_PM))

2018-03-11 22:52:29

by Matthias Brugger

Subject: Re: [PATCH] soc: mediatek: fix the mistaken pointer accessed when subdomains are added

On 02/08/2018 07:07 PM, [email protected] wrote:
> From: Sean Wang <[email protected]>
>
> Fix the pointer to struct scp_subdomian not being moved forward
> when each sub-domain is expected to be iteratively added through
> pm_genpd_add_subdomain call.
>
> Cc: [email protected]
> Fixes: 53fddb1a66dd ("soc: mediatek: reduce code duplication of scpsys_probe across all SoCs")
> Reported-by: Weiyi Lu <[email protected]>
> Signed-off-by: Sean Wang <[email protected]>

Pushed now to v4.16-next/soc

Thanks a lot

@stable this would need to be applied since v4.13

> ---
> drivers/soc/mediatek/mtk-scpsys.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c
> index fc55faa..9de801e 100644
> --- a/drivers/soc/mediatek/mtk-scpsys.c
> +++ b/drivers/soc/mediatek/mtk-scpsys.c
> @@ -1048,7 +1048,7 @@ static int scpsys_probe(struct platform_device *pdev)
>
> pd_data = &scp->pd_data;
>
> - for (i = 0, sd = soc->subdomains ; i < soc->num_subdomains ; i++) {
> + for (i = 0, sd = soc->subdomains; i < soc->num_subdomains; i++, sd++) {
> ret = pm_genpd_add_subdomain(pd_data->domains[sd->origin],
> pd_data->domains[sd->subdomain]);
> if (ret && IS_ENABLED(CONFIG_PM))
>