Hi all,
Commit
aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
is missing a Signed-off-by from its author.
--
Cheers,
Stephen Rothwell
On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
>
> is missing a Signed-off-by from its author.
Doug, something went wrong with your scripts
In patchworks it is with SOB and lengthy commit message:
https://patchwork.kernel.org/patch/10264089/
In the tree, it is cut:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-rc&id=aa0de36a40f446f5a21a7c1e677b98206e242edb
Thanks
>
> --
> Cheers,
> Stephen Rothwell
On Thu, 2018-03-08 at 08:09 +0200, Leon Romanovsky wrote:
> On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
> >
> > is missing a Signed-off-by from its author.
>
> Doug, something went wrong with your scripts
>
> In patchworks it is with SOB and lengthy commit message:
> https://patchwork.kernel.org/patch/10264089/
>
> In the tree, it is cut:
> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-rc&id=aa0de36a40f446f5a21a7c1e677b98206e242edb
I use git am -s <mboxfile> to bring the patch in, so this usually
indicates that there was something wrong with the email and it caused
patchworks to improperly parse it. Sure enough, when I look in
patchworks (https://patchwork.kernel.org/patch/10264089/, the exact link
you listed above so I'm surprised you didn't catch this), patchworks
parsed that separator line you put in the commit message:
====================================================================
as the end of message and start of patch. So, in patchworks, that line
and everything after it is considered part of the patch and not part of
the message. So, when I download the mbox file, patchworks placed this:
---
2.6.12
at the end of the truncated commit message, so git am would also ignore
everything after your separator line.
Anyway, I've hand edited the mbox file and I pushed a rebased version of
my wip branch. However, during the night Jason must have moved my
wip/for-rc branch to the official for-rc because it's there now, so the
only way to fix this (that I know of) in our official for-rc branch is a
rebase :-(
FWIW, be careful using those big separator lines like that. They can
and, as you see here, do trip up the automated tools sometimes :-(.
Would be better to just not put a guard around the copied in stuff.
--
Doug Ledford <[email protected]>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
On Thu, Mar 08, 2018 at 08:28:45AM -0500, Doug Ledford wrote:
> On Thu, 2018-03-08 at 08:09 +0200, Leon Romanovsky wrote:
> > On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Commit
> > >
> > > aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
> > >
> > > is missing a Signed-off-by from its author.
> >
> > Doug, something went wrong with your scripts
> >
> > In patchworks it is with SOB and lengthy commit message:
> > https://patchwork.kernel.org/patch/10264089/
> >
> > In the tree, it is cut:
> > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-rc&id=aa0de36a40f446f5a21a7c1e677b98206e242edb
>
> I use git am -s <mboxfile> to bring the patch in, so this usually
> indicates that there was something wrong with the email and it caused
> patchworks to improperly parse it. Sure enough, when I look in
> patchworks (https://patchwork.kernel.org/patch/10264089/, the exact link
> you listed above so I'm surprised you didn't catch this), patchworks
> parsed that separator line you put in the commit message:
> ====================================================================
> as the end of message and start of patch. So, in patchworks, that line
> and everything after it is considered part of the patch and not part of
> the message. So, when I download the mbox file, patchworks placed this:
>
> ---
> 2.6.12
>
> at the end of the truncated commit message, so git am would also ignore
> everything after your separator line.
>
> Anyway, I've hand edited the mbox file and I pushed a rebased version of
> my wip branch. However, during the night Jason must have moved my
> wip/for-rc branch to the official for-rc because it's there now, so the
> only way to fix this (that I know of) in our official for-rc branch is a
> rebase :-(
It is harmless and not worth of rebase at all. Leave it as is. Thanks Doug.
>
> FWIW, be careful using those big separator lines like that. They can
> and, as you see here, do trip up the automated tools sometimes :-(.
> Would be better to just not put a guard around the copied in stuff.
I'll do and will clean it from my next patches.
Thanks again.
>
> --
> Doug Ledford <[email protected]>
> GPG KeyID: B826A3330E572FDD
> Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
On Thu, Mar 08, 2018 at 08:28:45AM -0500, Doug Ledford wrote:
> Anyway, I've hand edited the mbox file and I pushed a rebased version of
> my wip branch. However, during the night Jason must have moved my
> wip/for-rc branch to the official for-rc because it's there now, so the
> only way to fix this (that I know of) in our official for-rc branch is a
> rebase :-(
Yes, to get it into for-next so we could send to linus soon
Jason
On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> Hi all,
>
> Commit
>
> aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
>
> is missing a Signed-off-by from its author.
Thanks Stephen,
May I suggest to the checkpatch maintainers that checkpack should look
for this too?
Thanks,
Jason
On Thu, 2018-03-08 at 09:18 -0700, Jason Gunthorpe wrote:
> On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> > Hi all,
> >
> > Commit
> >
> > aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
> >
> > is missing a Signed-off-by from its author.
>
> Thanks Stephen,
>
> May I suggest to the checkpatch maintainers that checkpack should look
> for this too?
No such commit in current -hext
$ git status HEAD
HEAD detached at next-20180308
checkpatch doesn't try to match email sender to sign-off
as the email sender doesn't have to sign-off on a patch.
It currently does:
if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) {
ERROR("MISSING_SIGN_OFF",
"Missing Signed-off-by: line(s)\n");
}
On Thu, Mar 08, 2018 at 08:39:38AM -0800, Joe Perches wrote:
> On Thu, 2018-03-08 at 09:18 -0700, Jason Gunthorpe wrote:
> > On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > Commit
> > >
> > > aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
> > >
> > > is missing a Signed-off-by from its author.
> >
> > Thanks Stephen,
> >
> > May I suggest to the checkpatch maintainers that checkpack should look
> > for this too?
>
> No such commit in current -hext
> $ git status HEAD
> HEAD detached at next-20180308
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-rc&id=aa0de36a40f446f5a21a7c1e677b98206e242edb
> checkpatch doesn't try to match email sender to sign-off
> as the email sender doesn't have to sign-off on a patch.
>
> It currently does:
>
> if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) {
> ERROR("MISSING_SIGN_OFF",
> "Missing Signed-off-by: line(s)\n");
> }
If I were to suggest an exact check it would be that the commit git
author and commit git commiter both have signed-off-by lines, as I
can't think of any cases where it would be appropriate for them to be
missing?
Jason
On Thu, 2018-03-08 at 10:03 -0700, Jason Gunthorpe wrote:
> On Thu, Mar 08, 2018 at 08:39:38AM -0800, Joe Perches wrote:
> > On Thu, 2018-03-08 at 09:18 -0700, Jason Gunthorpe wrote:
> > > On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > Commit
> > > >
> > > > aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
> > > >
> > > > is missing a Signed-off-by from its author.
> > >
> > > Thanks Stephen,
> > >
> > > May I suggest to the checkpatch maintainers that checkpack should look
> > > for this too?
> >
> > No such commit in current -hext
> > $ git status HEAD
> > HEAD detached at next-20180308
>
> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-rc&id=aa0de36a40f446f5a21a7c1e677b98206e242edb
>
> > checkpatch doesn't try to match email sender to sign-off
> > as the email sender doesn't have to sign-off on a patch.
> >
> > It currently does:
> >
> > if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) {
> > ERROR("MISSING_SIGN_OFF",
> > "Missing Signed-off-by: line(s)\n");
> > }
>
> If I were to suggest an exact check it would be that the commit git
> author and commit git commiter both have signed-off-by lines,
The git commit committer can't be known by checkpatch.
It just looks at patches.
The original author of any patch can't be known either.
There is a mechanism to add a "From:" line that is
supposed to represent the sender of the patch, but that
person may not be the original author.
On Thu, Mar 08, 2018 at 09:23:12AM -0800, Joe Perches wrote:
> On Thu, 2018-03-08 at 10:03 -0700, Jason Gunthorpe wrote:
> > On Thu, Mar 08, 2018 at 08:39:38AM -0800, Joe Perches wrote:
> > > On Thu, 2018-03-08 at 09:18 -0700, Jason Gunthorpe wrote:
> > > > On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote:
> > > > > Hi all,
> > > > >
> > > > > Commit
> > > > >
> > > > > aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ")
> > > > >
> > > > > is missing a Signed-off-by from its author.
> > > >
> > > > Thanks Stephen,
> > > >
> > > > May I suggest to the checkpatch maintainers that checkpack should look
> > > > for this too?
> > >
> > > No such commit in current -hext
> > > $ git status HEAD
> > > HEAD detached at next-20180308
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?h=for-rc&id=aa0de36a40f446f5a21a7c1e677b98206e242edb
> >
> > > checkpatch doesn't try to match email sender to sign-off
> > > as the email sender doesn't have to sign-off on a patch.
> > >
> > > It currently does:
> > >
> > > if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) {
> > > ERROR("MISSING_SIGN_OFF",
> > > "Missing Signed-off-by: line(s)\n");
> > > }
> >
> > If I were to suggest an exact check it would be that the commit git
> > author and commit git commiter both have signed-off-by lines,
>
> The git commit committer can't be known by checkpatch.
>
> It just looks at patches.
Well, it would have to extract the git From line and look up the
commit ID in the local git to find that information. Obviously not a
work flow for everyone..
> The original author of any patch can't be known either.
>
> There is a mechanism to add a "From:" line that is
> supposed to represent the sender of the patch, but that
> person may not be the original author.
Well, I would be happy if checkpatch computed the author the same way
git-am did and used that to check the signed-off-by ..
If I recall, git am looks for a 'From ' header at the top of the body
to override the email header?
I only ask becuase I keep seeing these reports from Stephen and
usuaully by the time it gets to him it requires a disruptive rebase to
fix..
Jason
On Thu, 2018-03-08 at 10:44 -0700, Jason Gunthorpe wrote:
> I only ask becuase I keep seeing these reports from Stephen and
> usuaully by the time it gets to him it requires a disruptive rebase to
> fix..
If it's a part of a series, it will always require a rebase.
Generally, I think it's a small and relatively unlikely
problem for checkpatch to bother with as there's already
a reporting mechanism in-place.