2018-03-09 06:59:23

by Gabriel FERNANDEZ

[permalink] [raw]
Subject: [PATCH RESEND 0/2] Add dsi clock for stm32f469 board

From: Gabriel Fernandez <[email protected]>

This patch-set adds the dsi clock for stm32f469 board.

Gabriel Fernandez (2):
clk: stm32: END_PRIMARY_CLK should be declare after CLK_SYSCLK
clk: stm32: Add DSI clock for STM32F469 Board

drivers/clk/clk-stm32f4.c | 11 ++++++++++-
include/dt-bindings/clock/stm32fx-clock.h | 7 ++++---
2 files changed, 14 insertions(+), 4 deletions(-)

--
1.9.1



2018-03-09 06:59:45

by Gabriel FERNANDEZ

[permalink] [raw]
Subject: [PATCH RESEND 2/2] clk: stm32: Add DSI clock for STM32F469 Board

From: Gabriel Fernandez <[email protected]>

This patch adds DSI clock for STM32F469 board

Signed-off-by: Gabriel Fernandez <[email protected]>
---
drivers/clk/clk-stm32f4.c | 11 ++++++++++-
include/dt-bindings/clock/stm32fx-clock.h | 3 ++-
2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
index 96c6b6b..d15bae6 100644
--- a/drivers/clk/clk-stm32f4.c
+++ b/drivers/clk/clk-stm32f4.c
@@ -521,7 +521,7 @@ struct stm32f4_pll_data {
};

static const struct stm32f4_pll_data stm32f469_pll[MAX_PLL_DIV] = {
- { PLL, 50, { "pll", "pll-q", NULL } },
+ { PLL, 50, { "pll", "pll-q", "pll-r" } },
{ PLL_I2S, 50, { "plli2s-p", "plli2s-q", "plli2s-r" } },
{ PLL_SAI, 50, { "pllsai-p", "pllsai-q", "pllsai-r" } },
};
@@ -1047,6 +1047,8 @@ static struct clk_hw *stm32_register_cclk(struct device *dev, const char *name,
"no-clock", "lse", "lsi", "hse-rtc"
};

+static const char *dsi_parent[2] = { NULL, "pll-r" };
+
static const char *lcd_parent[1] = { "pllsai-r-div" };

static const char *i2s_parents[2] = { "plli2s-r", NULL };
@@ -1156,6 +1158,12 @@ struct stm32f4_clk_data {
NO_GATE, 0,
0
},
+ {
+ CLK_F469_DSI, "dsi", dsi_parent, ARRAY_SIZE(dsi_parent),
+ STM32F4_RCC_DCKCFGR, 29, 1,
+ STM32F4_RCC_APB2ENR, 27,
+ CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT
+ },
};

static const struct stm32_aux_clk stm32f746_aux_clk[] = {
@@ -1450,6 +1458,7 @@ static void __init stm32f4_rcc_init(struct device_node *np)
stm32f4_gate_map = data->gates_map;

hse_clk = of_clk_get_parent_name(np, 0);
+ dsi_parent[0] = hse_clk;

i2s_in_clk = of_clk_get_parent_name(np, 1);

diff --git a/include/dt-bindings/clock/stm32fx-clock.h b/include/dt-bindings/clock/stm32fx-clock.h
index 4d523b0..58d8b51 100644
--- a/include/dt-bindings/clock/stm32fx-clock.h
+++ b/include/dt-bindings/clock/stm32fx-clock.h
@@ -35,8 +35,9 @@
#define CLK_SAIQ_PDIV 13
#define CLK_HSI 14
#define CLK_SYSCLK 15
+#define CLK_F469_DSI 16

-#define END_PRIMARY_CLK 16
+#define END_PRIMARY_CLK 17

#define CLK_HDMI_CEC 16
#define CLK_SPDIF 17
--
1.9.1


2018-03-09 07:00:20

by Gabriel FERNANDEZ

[permalink] [raw]
Subject: [PATCH RESEND 1/2] clk: stm32: END_PRIMARY_CLK should be declare after CLK_SYSCLK

From: Gabriel Fernandez <[email protected]>

Update of END_PRIMARY_CLK was missed, it should be after CLK_SYSCLK
hsi and sysclk are overwritten by gpioa and gpiob.

Signed-off-by: Gabriel Fernandez <[email protected]>
Tested-by: Philippe Cornu <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
---
include/dt-bindings/clock/stm32fx-clock.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/include/dt-bindings/clock/stm32fx-clock.h b/include/dt-bindings/clock/stm32fx-clock.h
index 49bb3c2..4d523b0 100644
--- a/include/dt-bindings/clock/stm32fx-clock.h
+++ b/include/dt-bindings/clock/stm32fx-clock.h
@@ -33,11 +33,11 @@
#define CLK_SAI2 11
#define CLK_I2SQ_PDIV 12
#define CLK_SAIQ_PDIV 13
-
-#define END_PRIMARY_CLK 14
-
#define CLK_HSI 14
#define CLK_SYSCLK 15
+
+#define END_PRIMARY_CLK 16
+
#define CLK_HDMI_CEC 16
#define CLK_SPDIF 17
#define CLK_USART1 18
--
1.9.1


2018-03-18 13:00:48

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH RESEND 2/2] clk: stm32: Add DSI clock for STM32F469 Board

On Fri, Mar 09, 2018 at 07:57:31AM +0100, [email protected] wrote:
> From: Gabriel Fernandez <[email protected]>
>
> This patch adds DSI clock for STM32F469 board
>
> Signed-off-by: Gabriel Fernandez <[email protected]>
> ---
> drivers/clk/clk-stm32f4.c | 11 ++++++++++-
> include/dt-bindings/clock/stm32fx-clock.h | 3 ++-
> 2 files changed, 12 insertions(+), 2 deletions(-)

Reviewed-by: Rob Herring <[email protected]>

>
> diff --git a/drivers/clk/clk-stm32f4.c b/drivers/clk/clk-stm32f4.c
> index 96c6b6b..d15bae6 100644
> --- a/drivers/clk/clk-stm32f4.c
> +++ b/drivers/clk/clk-stm32f4.c
> @@ -521,7 +521,7 @@ struct stm32f4_pll_data {
> };
>
> static const struct stm32f4_pll_data stm32f469_pll[MAX_PLL_DIV] = {
> - { PLL, 50, { "pll", "pll-q", NULL } },
> + { PLL, 50, { "pll", "pll-q", "pll-r" } },
> { PLL_I2S, 50, { "plli2s-p", "plli2s-q", "plli2s-r" } },
> { PLL_SAI, 50, { "pllsai-p", "pllsai-q", "pllsai-r" } },
> };
> @@ -1047,6 +1047,8 @@ static struct clk_hw *stm32_register_cclk(struct device *dev, const char *name,
> "no-clock", "lse", "lsi", "hse-rtc"
> };
>
> +static const char *dsi_parent[2] = { NULL, "pll-r" };
> +
> static const char *lcd_parent[1] = { "pllsai-r-div" };
>
> static const char *i2s_parents[2] = { "plli2s-r", NULL };
> @@ -1156,6 +1158,12 @@ struct stm32f4_clk_data {
> NO_GATE, 0,
> 0
> },
> + {
> + CLK_F469_DSI, "dsi", dsi_parent, ARRAY_SIZE(dsi_parent),
> + STM32F4_RCC_DCKCFGR, 29, 1,
> + STM32F4_RCC_APB2ENR, 27,
> + CLK_SET_RATE_PARENT | CLK_SET_RATE_NO_REPARENT
> + },
> };
>
> static const struct stm32_aux_clk stm32f746_aux_clk[] = {
> @@ -1450,6 +1458,7 @@ static void __init stm32f4_rcc_init(struct device_node *np)
> stm32f4_gate_map = data->gates_map;
>
> hse_clk = of_clk_get_parent_name(np, 0);
> + dsi_parent[0] = hse_clk;
>
> i2s_in_clk = of_clk_get_parent_name(np, 1);
>
> diff --git a/include/dt-bindings/clock/stm32fx-clock.h b/include/dt-bindings/clock/stm32fx-clock.h
> index 4d523b0..58d8b51 100644
> --- a/include/dt-bindings/clock/stm32fx-clock.h
> +++ b/include/dt-bindings/clock/stm32fx-clock.h
> @@ -35,8 +35,9 @@
> #define CLK_SAIQ_PDIV 13
> #define CLK_HSI 14
> #define CLK_SYSCLK 15
> +#define CLK_F469_DSI 16
>
> -#define END_PRIMARY_CLK 16
> +#define END_PRIMARY_CLK 17
>
> #define CLK_HDMI_CEC 16
> #define CLK_SPDIF 17
> --
> 1.9.1
>

2018-03-19 20:47:50

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH RESEND 1/2] clk: stm32: END_PRIMARY_CLK should be declare after CLK_SYSCLK

Quoting [email protected] (2018-03-08 22:57:30)
> From: Gabriel Fernandez <[email protected]>
>
> Update of END_PRIMARY_CLK was missed, it should be after CLK_SYSCLK
> hsi and sysclk are overwritten by gpioa and gpiob.
>
> Signed-off-by: Gabriel Fernandez <[email protected]>
> Tested-by: Philippe Cornu <[email protected]>
> Reviewed-by: Rob Herring <[email protected]>
> ---

Applied to clk-next


2018-03-19 20:50:05

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH RESEND 2/2] clk: stm32: Add DSI clock for STM32F469 Board

Quoting [email protected] (2018-03-08 22:57:31)
> From: Gabriel Fernandez <[email protected]>
>
> This patch adds DSI clock for STM32F469 board
>
> Signed-off-by: Gabriel Fernandez <[email protected]>
> ---

Applied to clk-next


2018-03-20 08:21:53

by Gabriel FERNANDEZ

[permalink] [raw]
Subject: Re: [PATCH RESEND 2/2] clk: stm32: Add DSI clock for STM32F469 Board

Thanks Stephen !

Best Regards

Gabriel


On 03/19/2018 09:45 PM, Stephen Boyd wrote:
> Quoting [email protected] (2018-03-08 22:57:31)
>> From: Gabriel Fernandez <[email protected]>
>>
>> This patch adds DSI clock for STM32F469 board
>>
>> Signed-off-by: Gabriel Fernandez <[email protected]>
>> ---
> Applied to clk-next
>