2018-03-14 13:42:17

by John Pittman

Subject: [PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()

In the comment for function alua_alloc_pg() the argument '@h' is
mistakenly referred to. Fix this by replacing it with the correct
argument reference, '@tpgs', and provide a short description.

Signed-off-by: John Pittman <[email protected]>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 4b44325..ab89e42 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -214,8 +214,8 @@ static struct alua_port_group *alua_find_get_pg(char *id_str, size_t id_size,
/*
* alua_alloc_pg - Allocate a new port_group structure
* @sdev: scsi device
- * @h: alua device_handler data
* @group_id: port group id
+ * @tpgs: target port group settings
*
* Allocate a new port_group structure for a given
* device.
--
2.7.5

2018-03-14 13:46:22

by Martin K. Petersen

Subject: Re: [PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()

John,

> In the comment for function alua_alloc_pg() the argument '@h' is
> mistakenly referred to. Fix this by replacing it with the correct
> argument reference, '@tpgs', and provide a short description.

Please submit to [email protected]. Otherwise the patch won't
get picked up by patchwork.

--
Martin K. Petersen Oracle Linux Engineering