2018-03-20 11:00:32

by Daniel Gimpelevich

[permalink] [raw]
Subject: [PATCH v2] USB: misc: uss720: more vendor/product ID's

Reporting two more VID/PID pairs that work with this driver, having used
an informational webpage <http://reboots.g-cipher.net/lcd/> as a buying
guide now. The page listed additional working VID/PID pairs but did not
include these two. None were upstreamed. Also taking this opportunity to
sort the pairs numerically.

Of the two such cables now in my possession, one is white, bearing the
In-System Design ISD-103 label on one side, sold as an Epson CAEUL0002
"USB to Parallel Smart Cable For Apple Macintosh Computers" (04b8:0002),
and the other is black, bearing the In-System Design ISD-101 label on one
side, sold as an early Belkin F5U002 (05ab:0002).

Signed-off-by: Daniel Gimpelevich <[email protected]>
---
drivers/usb/misc/uss720.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index 263c97f..de9a502 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -769,10 +769,15 @@ static void uss720_disconnect(struct usb_interface *intf)
/* table of cables that work through this driver */
static const struct usb_device_id uss720_table[] = {
{ USB_DEVICE(0x047e, 0x1001) },
+ { USB_DEVICE(0x04b8, 0x0002) },
+ { USB_DEVICE(0x04b8, 0x0003) },
+ { USB_DEVICE(0x050d, 0x0002) },
+ { USB_DEVICE(0x050d, 0x1202) },
{ USB_DEVICE(0x0557, 0x2001) },
+ { USB_DEVICE(0x05ab, 0x0002) },
+ { USB_DEVICE(0x06c6, 0x0100) },
{ USB_DEVICE(0x0729, 0x1284) },
{ USB_DEVICE(0x1293, 0x0002) },
- { USB_DEVICE(0x050d, 0x0002) },
{ } /* Terminating entry */
};

--
1.9.1



2018-03-20 11:29:16

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2] USB: misc: uss720: more vendor/product ID's

On Tue, Mar 20, 2018 at 03:58:47AM -0700, Daniel Gimpelevich wrote:
> Reporting two more VID/PID pairs that work with this driver, having used
> an informational webpage <http://reboots.g-cipher.net/lcd/> as a buying
> guide now. The page listed additional working VID/PID pairs but did not
> include these two. None were upstreamed. Also taking this opportunity to
> sort the pairs numerically.
>
> Of the two such cables now in my possession, one is white, bearing the
> In-System Design ISD-103 label on one side, sold as an Epson CAEUL0002
> "USB to Parallel Smart Cable For Apple Macintosh Computers" (04b8:0002),
> and the other is black, bearing the In-System Design ISD-101 label on one
> side, sold as an early Belkin F5U002 (05ab:0002).
>
> Signed-off-by: Daniel Gimpelevich <[email protected]>
> ---
> drivers/usb/misc/uss720.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)

For the next time, you should put the versioning of the patch below the
--- line, saying what changed in each version, so we remember what is
going on here.

thanks,

greg k-h