2023-06-21 23:15:54

by Rob Herring (Arm)

Subject: [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema

The conditional if/then schema has an error as the "enum" values have
"const" in them. Drop the "const".

Signed-off-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
index 43a4b880534c..580fbe37b37f 100644
--- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
@@ -115,8 +115,8 @@ allOf:
compatible:
contains:
enum:
- - const: brcm,bcm4908-usb-phy
- - const: brcm,brcmstb-usb-phy
+ - brcm,bcm4908-usb-phy
+ - brcm,brcmstb-usb-phy
then:
properties:
reg:
--
2.40.1

2023-06-22 06:45:03

by Rafał Miłecki

Subject: Re: [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema

On 22.06.2023 01:09, Rob Herring wrote:
> The conditional if/then schema has an error as the "enum" values have
> "const" in them. Drop the "const".
>
> Signed-off-by: Rob Herring <[email protected]>

Oops, it's my mistake.

Fixes: 46b616c1574d ("dt-bindings: phy: brcm, brcmstb-usb-phy: add BCM4908 binding")

Acked-by: Rafał Miłecki <[email protected]>

Thanks!


> ---
> .../devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> index 43a4b880534c..580fbe37b37f 100644
> --- a/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/brcm,brcmstb-usb-phy.yaml
> @@ -115,8 +115,8 @@ allOf:
> compatible:
> contains:
> enum:
> - - const: brcm,bcm4908-usb-phy
> - - const: brcm,brcmstb-usb-phy
> + - brcm,bcm4908-usb-phy
> + - brcm,brcmstb-usb-phy
> then:
> properties:
> reg:

2023-06-22 08:09:13

by Vinod Koul

Subject: Re: [PATCH] dt-bindings: phy: brcm,brcmstb-usb-phy: Fix error in "compatible" conditional schema

On 21-06-23, 17:09, Rob Herring wrote:
> The conditional if/then schema has an error as the "enum" values have
> "const" in them. Drop the "const".

Applied, thanks

--
~Vinod