2021-11-02 23:57:13

by Giulio Benetti

[permalink] [raw]
Subject: [PATCH 0/7] Fix wrong static ip autoconf in some dts and defconfig

While trying to have a working nfsroot through RNDIS on sunxi I've found
that in bootargs <autoconf> must be set to 'off' to use a static ip setup,
but I've also found that the following boards have it set to 'on' that is
not the <autoconf> setting for static ip as stated here:
https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt

And most of all on sunxi RNDIS it doesn't work as static ip nfsroot.

Unfortunately I don't have such boards to give a build and a test, so if
there is someone who could give a try it would be great.

Best regards
---
Giulio Benetti
Benetti Engineering sas

Giulio Benetti (7):
ARM: dts: mmp2-brownstone: fix wrong static ip autoconf
ARM: dts: pxa168-aspenite: fix wrong static ip autoconf
ARM: dts: pxa910-dkb: fix wrong static ip autoconf
ARM: mmp2: update mmp2_defconfig to fix wrong static ip autoconf
ARM: pxa168: update pxa168_defconfig to fix wrong static ip autoconf
ARM: pxa3xx: update pxa3xx_defconfig to fix wrong static ip autoconf
ARM: pxa910: update pxa910_defconfig to fix wrong static ip autoconf

arch/arm/boot/dts/mmp2-brownstone.dts | 2 +-
arch/arm/boot/dts/pxa168-aspenite.dts | 2 +-
arch/arm/boot/dts/pxa910-dkb.dts | 2 +-
arch/arm/configs/mmp2_defconfig | 2 +-
arch/arm/configs/pxa168_defconfig | 2 +-
arch/arm/configs/pxa3xx_defconfig | 2 +-
arch/arm/configs/pxa910_defconfig | 2 +-
7 files changed, 7 insertions(+), 7 deletions(-)

--
2.25.1


2021-11-02 23:57:26

by Giulio Benetti

[permalink] [raw]
Subject: [PATCH 3/7] ARM: dts: pxa910-dkb: fix wrong static ip autoconf

At the moment <autoconf> field is set to 'on' but judging from the static
ip setting it should be set to 'off', since in [1] states:
```
<autoconf>
off or none: don't use autoconfiguration (do static IP assignment instead)
on or any: use any protocol available in the kernel (default)
```

So let's substitute <autoconf> 'on' with 'off'.

[1]: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt

Signed-off-by: Giulio Benetti <[email protected]>
---
arch/arm/boot/dts/pxa910-dkb.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/pxa910-dkb.dts b/arch/arm/boot/dts/pxa910-dkb.dts
index ce76158867c7..297a34f2ef2b 100644
--- a/arch/arm/boot/dts/pxa910-dkb.dts
+++ b/arch/arm/boot/dts/pxa910-dkb.dts
@@ -12,7 +12,7 @@ / {
compatible = "mrvl,pxa910-dkb", "mrvl,pxa910";

chosen {
- bootargs = "console=ttyS0,115200 root=/dev/nfs nfsroot=192.168.1.100:/nfsroot/ ip=192.168.1.101:192.168.1.100::255.255.255.0::eth0:on";
+ bootargs = "console=ttyS0,115200 root=/dev/nfs nfsroot=192.168.1.100:/nfsroot/ ip=192.168.1.101:192.168.1.100::255.255.255.0::eth0:off";
};

memory {
--
2.25.1

2021-11-02 23:57:39

by Giulio Benetti

[permalink] [raw]
Subject: [PATCH 5/7] ARM: pxa168: update pxa168_defconfig to fix wrong static ip autoconf

At the moment <autoconf> field is set to 'on' but judging from the static
ip setting it should be set to 'off', since in [1] states:
```
<autoconf>
off or none: don't use autoconfiguration (do static IP assignment instead)
on or any: use any protocol available in the kernel (default)
```

So let's substitute <autoconf> 'on' with 'off'.

[1]: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt

Signed-off-by: Giulio Benetti <[email protected]>
---
arch/arm/configs/pxa168_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/pxa168_defconfig b/arch/arm/configs/pxa168_defconfig
index 0947f022954d..3a972bae1be3 100644
--- a/arch/arm/configs/pxa168_defconfig
+++ b/arch/arm/configs/pxa168_defconfig
@@ -16,7 +16,7 @@ CONFIG_PREEMPT=y
CONFIG_AEABI=y
CONFIG_ZBOOT_ROM_TEXT=0x0
CONFIG_ZBOOT_ROM_BSS=0x0
-CONFIG_CMDLINE="root=/dev/nfs rootfstype=nfs nfsroot=192.168.2.100:/nfsroot/ ip=192.168.2.101:192.168.2.100::255.255.255.0::eth0:on console=ttyS0,115200 mem=128M"
+CONFIG_CMDLINE="root=/dev/nfs rootfstype=nfs nfsroot=192.168.2.100:/nfsroot/ ip=192.168.2.101:192.168.2.100::255.255.255.0::eth0:off console=ttyS0,115200 mem=128M"
CONFIG_FPE_NWFPE=y
CONFIG_NET=y
CONFIG_PACKET=y
--
2.25.1

2021-11-02 23:57:50

by Giulio Benetti

[permalink] [raw]
Subject: [PATCH 4/7] ARM: mmp2: update mmp2_defconfig to fix wrong static ip autoconf

At the moment <autoconf> field is set to 'on' but judging from the static
ip setting it should be set to 'off', since in [1] states:
```
<autoconf>
off or none: don't use autoconfiguration (do static IP assignment instead)
on or any: use any protocol available in the kernel (default)
```

So let's substitute <autoconf> 'on' with 'off'.

[1]: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt

Signed-off-by: Giulio Benetti <[email protected]>
---
arch/arm/configs/mmp2_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/mmp2_defconfig b/arch/arm/configs/mmp2_defconfig
index a5e8d2235a1a..231971ee0c8b 100644
--- a/arch/arm/configs/mmp2_defconfig
+++ b/arch/arm/configs/mmp2_defconfig
@@ -15,7 +15,7 @@ CONFIG_PREEMPT=y
CONFIG_AEABI=y
CONFIG_ZBOOT_ROM_TEXT=0x0
CONFIG_ZBOOT_ROM_BSS=0x0
-CONFIG_CMDLINE="root=/dev/nfs rootfstype=nfs nfsroot=192.168.1.100:/nfsroot/ ip=192.168.1.101:192.168.1.100::255.255.255.0::eth0:on console=ttyS2,38400 mem=128M user_debug=255 earlyprintk"
+CONFIG_CMDLINE="root=/dev/nfs rootfstype=nfs nfsroot=192.168.1.100:/nfsroot/ ip=192.168.1.101:192.168.1.100::255.255.255.0::eth0:off console=ttyS2,38400 mem=128M user_debug=255 earlyprintk"
CONFIG_VFP=y
CONFIG_NET=y
CONFIG_PACKET=y
--
2.25.1

2021-11-02 23:58:05

by Giulio Benetti

[permalink] [raw]
Subject: [PATCH 7/7] ARM: pxa910: update pxa910_defconfig to fix wrong static ip autoconf

At the moment <autoconf> field is set to 'on' but judging from the static
ip setting it should be set to 'off', since in [1] states:
```
<autoconf>
off or none: don't use autoconfiguration (do static IP assignment instead)
on or any: use any protocol available in the kernel (default)
```

So let's substitute <autoconf> 'on' with 'off'.

[1]: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt

Signed-off-by: Giulio Benetti <[email protected]>
---
arch/arm/configs/pxa910_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/configs/pxa910_defconfig b/arch/arm/configs/pxa910_defconfig
index b21196372158..36ced16095c8 100644
--- a/arch/arm/configs/pxa910_defconfig
+++ b/arch/arm/configs/pxa910_defconfig
@@ -16,7 +16,7 @@ CONFIG_PREEMPT=y
CONFIG_AEABI=y
CONFIG_ZBOOT_ROM_TEXT=0x0
CONFIG_ZBOOT_ROM_BSS=0x0
-CONFIG_CMDLINE="root=/dev/nfs rootfstype=nfs nfsroot=192.168.2.100:/nfsroot/ ip=192.168.2.101:192.168.2.100::255.255.255.0::eth0:on console=ttyS0,115200 mem=128M earlyprintk"
+CONFIG_CMDLINE="root=/dev/nfs rootfstype=nfs nfsroot=192.168.2.100:/nfsroot/ ip=192.168.2.101:192.168.2.100::255.255.255.0::eth0:off console=ttyS0,115200 mem=128M earlyprintk"
CONFIG_FPE_NWFPE=y
CONFIG_NET=y
CONFIG_PACKET=y
--
2.25.1

2021-11-02 23:58:19

by Giulio Benetti

[permalink] [raw]
Subject: [PATCH 2/7] ARM: dts: pxa168-aspenite: fix wrong static ip autoconf

At the moment <autoconf> field is set to 'on' but judging from the static
ip setting it should be set to 'off', since in [1] states:
```
<autoconf>
off or none: don't use autoconfiguration (do static IP assignment instead)
on or any: use any protocol available in the kernel (default)
```

So let's substitute <autoconf> 'on' with 'off'.

[1]: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt

Signed-off-by: Giulio Benetti <[email protected]>
---
arch/arm/boot/dts/pxa168-aspenite.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/pxa168-aspenite.dts b/arch/arm/boot/dts/pxa168-aspenite.dts
index 8bade6bf395b..68076f1c5cd3 100644
--- a/arch/arm/boot/dts/pxa168-aspenite.dts
+++ b/arch/arm/boot/dts/pxa168-aspenite.dts
@@ -12,7 +12,7 @@ / {
compatible = "mrvl,pxa168-aspenite", "mrvl,pxa168";

chosen {
- bootargs = "console=ttyS0,115200 root=/dev/nfs nfsroot=192.168.1.100:/nfsroot/ ip=192.168.1.101:192.168.1.100::255.255.255.0::eth0:on";
+ bootargs = "console=ttyS0,115200 root=/dev/nfs nfsroot=192.168.1.100:/nfsroot/ ip=192.168.1.101:192.168.1.100::255.255.255.0::eth0:off";
};

memory {
--
2.25.1

2021-11-02 23:59:21

by Giulio Benetti

[permalink] [raw]
Subject: [PATCH 1/7] ARM: dts: mmp2-brownstone: fix wrong static ip autoconf

At the moment <autoconf> field is set to 'on' but judging from the static
ip setting it should be set to 'off', since in [1] states:
```
<autoconf>
off or none: don't use autoconfiguration (do static IP assignment instead)
on or any: use any protocol available in the kernel (default)
```

So let's substitute <autoconf> 'on' with 'off'.

[1]: https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt

Signed-off-by: Giulio Benetti <[email protected]>
---
arch/arm/boot/dts/mmp2-brownstone.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/mmp2-brownstone.dts b/arch/arm/boot/dts/mmp2-brownstone.dts
index 04f1ae1382e7..05ccb567e516 100644
--- a/arch/arm/boot/dts/mmp2-brownstone.dts
+++ b/arch/arm/boot/dts/mmp2-brownstone.dts
@@ -12,7 +12,7 @@ / {
compatible = "mrvl,mmp2-brownstone", "mrvl,mmp2";

chosen {
- bootargs = "console=ttyS2,38400 root=/dev/nfs nfsroot=192.168.1.100:/nfsroot/ ip=192.168.1.101:192.168.1.100::255.255.255.0::eth0:on";
+ bootargs = "console=ttyS2,38400 root=/dev/nfs nfsroot=192.168.1.100:/nfsroot/ ip=192.168.1.101:192.168.1.100::255.255.255.0::eth0:off";
};

memory {
--
2.25.1

2022-01-21 18:09:35

by Giulio Benetti

[permalink] [raw]
Subject: Re: [PATCH 0/7] Fix wrong static ip autoconf in some dts and defconfig

Hello All,

kindly ping,

On 03/11/21 00:54, Giulio Benetti wrote:
> While trying to have a working nfsroot through RNDIS on sunxi I've found
> that in bootargs <autoconf> must be set to 'off' to use a static ip setup,
> but I've also found that the following boards have it set to 'on' that is
> not the <autoconf> setting for static ip as stated here:
> https://www.kernel.org/doc/Documentation/filesystems/nfs/nfsroot.txt

the documentantion states "<autoconf> must be set to 'off' to use a
static ip setup"...

> And most of all on sunxi RNDIS it doesn't work as static ip nfsroot.
>
> Unfortunately I don't have such boards to give a build and a test, so if
> there is someone who could give a try it would be great.

...so I don't even think it really deserves a test IMHO.

Best regards
--
Giulio Benetti
Benetti Engineering sas

> Best regards
> ---
> Giulio Benetti
> Benetti Engineering sas
>
> Giulio Benetti (7):
> ARM: dts: mmp2-brownstone: fix wrong static ip autoconf
> ARM: dts: pxa168-aspenite: fix wrong static ip autoconf
> ARM: dts: pxa910-dkb: fix wrong static ip autoconf
> ARM: mmp2: update mmp2_defconfig to fix wrong static ip autoconf
> ARM: pxa168: update pxa168_defconfig to fix wrong static ip autoconf
> ARM: pxa3xx: update pxa3xx_defconfig to fix wrong static ip autoconf
> ARM: pxa910: update pxa910_defconfig to fix wrong static ip autoconf
>
> arch/arm/boot/dts/mmp2-brownstone.dts | 2 +-
> arch/arm/boot/dts/pxa168-aspenite.dts | 2 +-
> arch/arm/boot/dts/pxa910-dkb.dts | 2 +-
> arch/arm/configs/mmp2_defconfig | 2 +-
> arch/arm/configs/pxa168_defconfig | 2 +-
> arch/arm/configs/pxa3xx_defconfig | 2 +-
> arch/arm/configs/pxa910_defconfig | 2 +-
> 7 files changed, 7 insertions(+), 7 deletions(-)
>